Skip to content

refactor: Use parse_number in Position::parse #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheRealGioviok merged 1 commit into from
Jul 13, 2025
Merged

refactor: Use parse_number in Position::parse #109

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/position.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
#include "board.hpp"
#include "common.hpp"
#include "geometry.hpp"
#include "util/parse.hpp"
#include "util/types.hpp"
#include "zobrist.hpp"

Expand Down Expand Up @@ -476,7 +477,8 @@ const std::array<u16, 2> Position::calc_attacks_slow(Square sq) {
}

std::optional<Position> Position::parse(std::string_view str) {
std::istringstream is{std::string{str}};
std::string input{str};
std::istringstream is{input};

std::string board, color, castle, enpassant, irreversible_clock, ply;
is >> board >> color >> castle >> enpassant >> irreversible_clock >> ply;
Expand Down Expand Up @@ -655,15 +657,15 @@ std::optional<Position> Position::parse(std::string_view board,
}

// Parse 50mr clock
if (i32 value = std::stoi(std::string{irreversible_clock}); value <= 100) {
result.m_50mr = static_cast<u16>(value);
if (auto value = parse_number<i32>(irreversible_clock); value && *value <= 100) {
result.m_50mr = static_cast<u16>(*value);
} else {
return std::nullopt;
}

// Parse game ply
if (i32 value = std::stoi(std::string{ply}); value != 0 && value < 10000) {
result.m_ply = static_cast<u16>((value - 1) * 2 + static_cast<i32>(result.m_active_color));
if (auto value = parse_number<i32>(ply); value && *value != 0 && *value < 10000) {
result.m_ply = static_cast<u16>((*value - 1) * 2 + static_cast<i32>(result.m_active_color));
} else {
return std::nullopt;
}
Expand Down
Loading