[FIX] runbot: fetch threehash #1290
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, to export some threehash, the commit is used to check if the commit is present or not. This can be a problem when rebuilding an old build that was linked to a previous one by a threehash after a forcepush, because the old commit may not be known by github anymore. Not sure why it was the case since it looks like fetch works fine with a threehash, so fixing it by fetching the threehash should be enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, to export some threehash, the commit is used to check if the commit is present or not.
This can be a problem when rebuilding an old build that was linked to a previous one by a threehash after a forcepush, because the old commit may not be known by github anymore.
Not sure why it was the case since it looks like fetch works fine with a threehash, so fixing it by fetching the threehash should be enough.