[IMP] runbot: add a button to create missing trigger slots #1161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-fence
force-pushed
the
18.0-runbot-batch-missing-tiggers-moc
branch
from
85a7683 to
3a7a355
Compare
When creating a new trigger, especially for nightly builds, it's convenient to test the trigger. One way of doing that is by starting the trigger manually on the desired bundle instead of waiting for a new batch. But as the slot with the new trigger does not exists yet on batches it's not possible. With this commit, a button is added on the batch form in order to create the missing slots in the last batches of the sticky bundles.
Xavier-Do
reviewed
Dec 22, 2025
Comment on lines
+513
to
+531
| for trigger in missing_trigger_ids: | ||
| params_value = { | ||
| 'version_id': self.bundle_id.version_id.id, | ||
| 'project_id': self.bundle_id.project_id.id, | ||
| 'create_batch_id': self.id, | ||
| 'config_id': trigger.config_id.id, | ||
| 'trigger_id': trigger.id, | ||
| 'config_data': dict(trigger.config_data or {}), | ||
| 'modules': bundle.modules, | ||
| 'dockerfile_id': dockerfile_id.id, | ||
| 'commit_link_ids': [(6, 0, self.commit_link_ids.ids)], | ||
| } | ||
| params = self.env['runbot.build.params'].create(params_value) | ||
| self.env['runbot.batch.slot'].create({ | ||
| 'batch_id': self.id, | ||
| 'trigger_id': trigger.id, | ||
| 'params_id': params.id, | ||
| 'link_type': 'created', | ||
| }) |
Contributor
There was a problem hiding this comment.
I wonder if this logic shouldn't be refactored with the prapare logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.