cleanup variable scoping

[ged-odoo]

No description provided.

[sdegueldre]

Related problem: t-foreach cannot shadow properties for which a getter or setter exists in the rendering context (playground), the set expression silently fails. In the same vein, if a setter exists, it will be invoked instead of declaring a shadowing "local".

Attempting to t-set a value for which a getter exists on the component will crash with TypeError: Cannot set property x of #<Object> which has only a getter (playground).

Whether this crashes (as with t-set) or fails silently (as in t-foreach) depends on whether the set expression is executed in strict mode. the t-foreach set expression is in the compiled template which is not strict mode (should they be?) or in the owl code (t-set invokes setContextValue that invokes the actual set expression), which is either in a module which is implicitly strict mode, or in an IIFE that's explicitly set to strict mode by the bundling toolchain.

PS: while the problem becomes less prominent/annoying without implicit this, it remains a problem for t-call-context . In practice I don't think it would be common for t-call-context to be passed a context with setters/getters, unlike components in which this is common, so it may be a non-issue in practice starting in owl3.