[IMP] Sales: Aligning 'Optional products' page#16686
Open
theRealThagomizer wants to merge 1 commit into17.0from
Open
[IMP] Sales: Aligning 'Optional products' page#16686theRealThagomizer wants to merge 1 commit into17.0from
theRealThagomizer wants to merge 1 commit into17.0from
Conversation
Collaborator
|
|
larm-odoo
requested changes
Mar 5, 2026
Contributor
larm-odoo
left a comment
larm-odoo
left a comment
There was a problem hiding this comment.
Hi @theRealThagomizer - great job! Most of these are optional, and I wrote down any reasons for my suggestions just to give you some context. If you have any questions, please let me know. Tag me agian for a quick peek when you're done, and I promise to review it again ASAP - I apologize for the delay with this one.
content/applications/sales/sales/send_quotations/optional_products.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/send_quotations/optional_products.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/send_quotations/optional_products.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/send_quotations/optional_products.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/send_quotations/optional_products.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/send_quotations/optional_products.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/send_quotations/optional_products.rst
Outdated
Show resolved
Hide resolved
content/applications/sales/sales/send_quotations/optional_products.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: larm-odoo <121518652+larm-odoo@users.noreply.github.com>
theRealThagomizer
force-pushed
the
17.0-sales-optional-products-update-thjud
branch
from
e415888 to
335fb4b
Compare
Contributor
Author
|
Hiya, @larm-odoo! I think I implemented all of the changes you indicated; I went through resolving things as I went just to try and keep things straight, but I believe I responded to/addressed everything. Please let me know if you have more feedback or if there's anything I missed. Thanks! |
Contributor
Author
|
Hiya, @larm-odoo! Just wanted to resurface this ahead of you being OoO next week. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hiya, @larm-odoo! This file is a 17.0 update of the optional products page (remember that big rework I did back in December?) This redoes the images to match current standards, reorganizes the information to flow more logically, and tweaks some of the details so they more accurately capture what the user experiences when they actually try to use optional products with quotations and quotation templates. Thank you!
This 17.0 PR can be FWP up to saas-18.4.