[2.5] Invalidate .install fields containing destination filepath trying to escape their scope#6898
Merged
kit-ty-kate merged 3 commits intoocaml:2.5from Apr 15, 2026
Merged
Conversation
…tion filepath trying to escape their scope
Member
|
Thanks Kate! Just wanted to note credit for reporting this is @andrew (Andrew Nesbitt) |
…escape their scope Absolute filepaths and paths containing '..' were already forbidden by the opam manual. Per the <pkgname>.install section: > Absolute paths, or paths referencing the parent directory (..), are not allowed.
kit-ty-kate
force-pushed
the
2.5-fix-dotinstall-escape
branch
from
9de6c01 to
da30943
Compare
rjbou
approved these changes
Apr 15, 2026
Member
Author
yes don't worry this will be in the advisory, the release note and the blog and discuss posts |
Member
Author
|
Not waiting for the Windows/msvc/5.4.0 CI run which is taking longer than usual (nearing two hours), merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #6897 on the 2.5 branch