nix depexts: load from json instead of inlining package names#6894
Merged
kit-ty-kate merged 1 commit intoocaml:masterfrom Apr 16, 2026
Merged
nix depexts: load from json instead of inlining package names#6894kit-ty-kate merged 1 commit intoocaml:masterfrom
kit-ty-kate merged 1 commit intoocaml:masterfrom
Conversation
rjbou
approved these changes
Apr 15, 2026
Collaborator
rjbou
left a comment
rjbou
left a comment
There was a problem hiding this comment.
LGTM!
Tested locally, and it changes well the derivation parsing error to a less harmful json parsing error.
kit-ty-kate
force-pushed
the
nix-depext-packages-json
branch
from
621741a to
d2259c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed and tested by @RyanGibb
The following pattern was allowed:
The json values can include strings trying to escape the json, but the
map (name: buildPackages.${name})ensures any value will either be correct or make nix-build fail which is a reasonable behaviour. Nix syntax does not work like bash and thus ensure that nothing can escape the${name}.Backported to 2.5 in #6895