Skip to content

10 packages from savonet/ocaml-posix at 3.1.0#29128

Closed
toots wants to merge 1 commit intoocaml:masterfrom
toots:opam-publish-posix-base.3.1.0
Closed

10 packages from savonet/ocaml-posix at 3.1.0#29128
toots wants to merge 1 commit intoocaml:masterfrom
toots:opam-publish-posix-base.3.1.0

Conversation

@toots
Copy link
Contributor

@toots toots commented Dec 23, 2025

This pull-request concerns:

  • posix-base.3.1.0: Base module for the posix bindings
  • posix-bindings.3.1.0: POSIX bindings
  • posix-getopt.3.1.0: Bindings for posix getopt/getopt_long
  • posix-math2.3.1.0: Bindings for posix math
  • posix-signal.3.1.0: Bindings for the types defined in <signal.h>
  • posix-socket.3.1.0: Bindings for posix sockets
  • posix-socket-unix.3.1.0: Bindings for posix sockets
  • posix-time2.3.1.0: Bindings for posix time functions
  • posix-types.3.1.0: Bindings for the types defined in <sys/types.h>
  • posix-uname.3.1.0: Bindings for posix uname


🐫 Pull-request generated by opam-publish v2.7.0

@toots toots force-pushed the opam-publish-posix-base.3.1.0 branch 10 times, most recently from 5937aa8 to d5a81f8 Compare December 23, 2025 16:51
@toots toots marked this pull request as draft December 23, 2025 18:11
@toots toots marked this pull request as ready for review December 23, 2025 18:11
@toots toots marked this pull request as draft December 23, 2025 18:11
@toots toots force-pushed the opam-publish-posix-base.3.1.0 branch 9 times, most recently from 3df8223 to 930f104 Compare December 23, 2025 20:45
@toots toots marked this pull request as ready for review December 23, 2025 21:08
@toots toots force-pushed the opam-publish-posix-base.3.1.0 branch 3 times, most recently from fd7a5b5 to fa99740 Compare December 23, 2025 21:41
@toots toots force-pushed the opam-publish-posix-base.3.1.0 branch from fa99740 to be6f5a2 Compare December 23, 2025 22:12
]
dev-repo: "git+https://github.com/savonet/ocaml-posix.git"
x-maintenance-intent: ["(latest)"]
available: os != "win32" & os != "bsd"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you probably want os-family != "bsd" or os != "freebsd"
following https://github.com/ocaml/opam-repository/wiki/Depexts-os-distribution---os-family-values

@jmid
Copy link
Member

jmid commented Dec 23, 2025

After some rabbit-holing, I've learned more about the sandboxing of the opam repo.

Networking is disabled during runtest/with-test:
https://github.com/ocurrent/opam-repo-ci/blob/272a78339db1377f39b8693ce8993bb79eb8ab46/opam-ci-check/lib/opam_build.ml#L57
and these build on OBuilder's sandboxing:
https://github.com/ocurrent/obuilder?tab=readme-ov-file#run

The (network NETWORK…) field specifies which network(s) the container will be connected to. (network host) is a special value which runs the container in the host's network namespace. Otherwise, a fresh network namespace is created for the container, with interfaces for the given networks (if any).

Couldn't this explain the getaddrinfo across the board that we are seeing?

This is hinted at in the wiki, but I only understood the implications after finding the above:

https://github.com/ocaml/opam-repository/wiki/How-to-deal-with-CI#opam-repository-ci-results-vs-your-development-ci-results

If you're noticing errors that look genuine but never noticed before on your own CI it could be because:

  • [...]
  • we have a different opam setup: opam-repo-ci has the sandbox unable for both build and tests, which might not be the case in your own CI (e.g. if you’re using docker). Errors are typical here if you’re using the network (e.g. during the tests)

(I think it should read "has the sandbox enabled for both build and tests")

@toots
Copy link
Contributor Author

toots commented Jan 1, 2026

I personally do not think that the purpose of the opam repository CI should be to run the project's internal testing code. I typically have this issue with ocaml-ffmpeg as well. The internal project tests may require extensive, hardware and software specific setup that are out of the scope of the opam package CI. There should either be a opam repository test target explicitly or simple tests to check that the packaging is done properly in my opinion.

Those tests are run in several properly setup environment in the project's CI, including windows environment here: https://github.com/savonet/ocaml-posix/actions

I have some big changes pending in the current code, I think that I will resubmit with those and with the tests disabled.

Thanks for y'all work on maintaining this repository!

@toots toots closed this Jan 1, 2026
@toots toots deleted the opam-publish-posix-base.3.1.0 branch January 1, 2026 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants