Fix CI merge error by disabling windows workflow on pushes to master#29078
Merged
mseri merged 2 commits intoocaml:masterfrom Dec 12, 2025
Merged
Fix CI merge error by disabling windows workflow on pushes to master#29078mseri merged 2 commits intoocaml:masterfrom
master#29078mseri merged 2 commits intoocaml:masterfrom
Conversation
…ecks are disabled already
747f30a to
cafe15d
Compare
Member
Author
|
OK, this needed a bit back-and-forth but now it should be ready:
In summary:
|
Member
|
Thanks |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the merge of #29040 including 703ece7 I've been getting an error email every time I merge a PR.
(The email has
Subject: [ocaml/opam-repository] Run failed: Windows CI - master (9684018)and a body that says "Windows CI: All jobs were successful" ... but I digress 😅 )
Looking at the GitHub Actions CI interface, I observed that
Get changed filesis not run on a merge commit, since it is guarded byif: github.event_name != 'push', but the subsequent steps depending on the changed files info are still enabled:Up until 703ece7 the subsequent steps were similarly guarded, so I started by inserting those again.
I then realized that running a workflow on pushes to
masteronly to hit a series of disabled workflow steps that perform any actual checks makes little sense.This PR therefore disables the windows CI workflow on pushes to master (incl.merge) where checks are disabled already.
It should only make a difference to opam maintainers who hopefully won't get an error email after this.