-
Notifications
You must be signed in to change notification settings - Fork 245
add getSceneItemList, getSceneItemTransform & getBrowserInputSettings… #500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
add getSceneItemList, getSceneItemTransform & getBrowserInputSettings… #500
Conversation
|
Hi! Just checking in to see if there’s anything I can do to help get this PR reviewed :) I’m happy to split the functionality into smaller PRs or make any changes needed to align with project expectations, just let me know what needs to be done! Thank you and thanks a lot for maintaining the project. |
|
At a glance there doesn't seem to be anything major that you need to do. We review things as we have time, resources, and as priorities allow. |
|
👋 Hey friends, super interested in this as it'd unlock quite a bit for us with automating scene layout bits within a browser source. Anything I can do to help move this forward? |
| Permissions required: READ_USER | ||
| ```js | ||
| /** | ||
| * @typedef {Object} SceneItem |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would love to see transform (or at least position) information included for these, if that would be possible?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I built the feature as closely as possible to the existing WebSocket implementation, and that implementation does not include this.
I also don’t think this needs to be added directly to SceneItem:
With my implementation, you can first retrieve a scene item and then call getSceneItemTransform to get everything you might need: position, rotation, scale, bounds, and even whether it’s cropped (see screenshot 2 above).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah sorry I completely missed that getSceneItemTransform exposes all the scene items and not just the browser source itself!
|
I would love to have this also. Bump |
This is a follow up to: #499 as the previous approach failed when duplicating a browser source reference.
This time I tried to stay with the implementation more closely with how the WebSocket handles it and giving developers the same flexibility.
Description
This new feature adds:
Motivation and Context
I decided to bundle these three functions into a single PR since they are closely related:
How Has This Been Tested?
Environment: Windows 11 x64, OBS Studio 31.1.2 (build 104)
Types of changes
New feature (non-breaking change which adds functionality)
Documentation (a change to documentation pages)
Checklist: