Bear import fixes - #629
Merged
Merged
Conversation
Tags stay where Bear wrote them, with a setting to move them to a property instead. A tag ends before the punctuation that follows it, an escaped hash is text, a hash in code is code, and a hex colour is a colour. A table is separated from the paragraph above it, an image's width comment is written as a width Obsidian reads, and archive and trash folders are only created when something lands in them.
Obsidian reads a pair of tildes as strikethrough and one as nothing, so Bear's underline was lost.
Image sizes were rewritten inside a fence, a code span crossing a line ending was not seen as one, an escaped tilde was read as an underline, and a tag after a non-breaking space was extracted but never removed.
A code span now closes on a run as long as the one that opened it, and only a bare delimiter closes a fence, so the ```js opening an example inside a ```md block no longer ends it. One tracker answers for both passes that needed to know where a fence was, and a tag stops at the placeholder standing in for code.
separateTables ran before the masking and only knew about fences, so a table example inside a code span was broken apart. Masking once at the top of the conversion puts every pass behind it, asset links included, and leaves one caller for the fence tracker. A fence is also no longer recognised four spaces in, where the backticks are indented code.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
like #bear,became#bear_, losing the comma), an escaped\#is text.<u>for underlines since~is not supported.<!-- {"width":388} -->becomes![[image.png|388]].archiveandtrashare only created if they have notesSupersedes #511