Append 'phenotype' to UPHENO grouping class labels#1016
Merged
matentzn merged 1 commit intoobophenotype:masterfrom Apr 3, 2026
Merged
Append 'phenotype' to UPHENO grouping class labels#1016matentzn merged 1 commit intoobophenotype:masterfrom
matentzn merged 1 commit intoobophenotype:masterfrom
Conversation
Fix over-aggressive label trimming that produced labels clashing with terms in other ontologies (e.g. "axon", "actin cytoskeleton").
sbello
reviewed
Apr 3, 2026
Contributor
sbello
left a comment
There was a problem hiding this comment.
I think the label changes to add phenotype to the end of terms looks good.
I don't really like the (phenotype grouping) addition but I also don't really like those terms. I think the label addition may be helpful for pulling these out and reviewing these in the future to come up with a better solution.
I'm not sure why the QC is failing but the actual changes to the file look fine. Once it passes QC I'll take a second look.
sbello
approved these changes
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1012
Summary
Test plan