Skip to content

Append 'phenotype' to UPHENO grouping class labels#1016

Merged
matentzn merged 1 commit intoobophenotype:masterfrom
matentzn:fix/upheno-grouping-labels
Apr 3, 2026
Merged

Append 'phenotype' to UPHENO grouping class labels#1016
matentzn merged 1 commit intoobophenotype:masterfrom
matentzn:fix/upheno-grouping-labels

Conversation

@matentzn
Copy link
Copy Markdown
Collaborator

@matentzn matentzn commented Apr 3, 2026

Fixes #1012

Summary

  • Fix over-aggressive label trimming that produced labels clashing with terms in other ontologies (e.g. "axon", "actin cytoskeleton")
  • Appends 'phenotype' suffix to UPHENO grouping class labels to avoid collisions
  • Updates grouping template TSV with corrected labels

Test plan

  • Verify updated labels no longer clash with external ontology terms
  • Check pipeline runs successfully with updated labels

Fix over-aggressive label trimming that produced labels clashing
with terms in other ontologies (e.g. "axon", "actin cytoskeleton").
@matentzn matentzn requested a review from sbello April 3, 2026 10:23
Copy link
Copy Markdown
Contributor

@sbello sbello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the label changes to add phenotype to the end of terms looks good.
I don't really like the (phenotype grouping) addition but I also don't really like those terms. I think the label addition may be helpful for pulling these out and reviewing these in the future to come up with a better solution.
I'm not sure why the QC is failing but the actual changes to the file look fine. Once it passes QC I'll take a second look.

@matentzn matentzn merged commit 9edbd70 into obophenotype:master Apr 3, 2026
1 check failed
@matentzn matentzn deleted the fix/upheno-grouping-labels branch April 3, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

over aggressive label trimming

2 participants