refactor(spec-bridge): remove the dead page/dashboard bridges (#1892)#2817
Open
os-zhuang wants to merge 1 commit into
Open
refactor(spec-bridge): remove the dead page/dashboard bridges (#1892)#2817os-zhuang wants to merge 1 commit into
os-zhuang wants to merge 1 commit into
Conversation
`bridgePage`, `bridgeDashboard`, and the `SpecBridge#transformPage` / `#transformDashboard` methods had no runtime consumer: pages render through their own renderer and dashboards through `DashboardView → DashboardRenderer → DatasetWidget` (ADR-0021), neither routing through `SpecBridge`. The dashboard bridge's input shape (`object`/`categoryField`/`valueField`/`aggregate`) is the pre-ADR-0021 widget model, which the strict `DashboardWidgetSchema` now rejects, so the bridge could not receive a spec-valid dashboard even in principle. Flagged dead by the metadata-liveness audit (framework #1878 / #1892). The `list` and `form` bridges are the live authoring path and are untouched. BREAKING CHANGE: removes the public exports `bridgePage`, `bridgeDashboard`, and `SpecBridge#transformPage` / `#transformDashboard`. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
4 tasks
Contributor
✅ Console Performance Budget
📦 Bundle Size Report
Size Limits
|
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Deletes
SpecBridge's page and dashboard bridges —bridgePage,bridgeDashboard, and theSpecBridge#transformPage/#transformDashboardmethods — plus their tests. Thelistandformbridges are untouched and remain the live authoring path.Why
Both bridges are dead (flagged by the metadata-liveness audit, framework #1878 / #1892, cluster #5 "write-only / disconnected metadata"):
DashboardView → DashboardRenderer → DatasetWidget(ADR-0021). Neither routes throughSpecBridge. Repo-wide, the only references to the removed symbols were the bridges' own tests (verified via grep acrosspackages/apps/examples).object/categoryField/valueField/aggregate) is the pre-ADR-0021 widget model, which the strictDashboardWidgetSchemanow rejects. Reviving it would mean building a second, parallel render path — exactly what "enforce or remove" (ADR-0049 spirit) says not to do.Change
bridges/page.ts,bridges/dashboard.tsSpecBridge.tstransformPage/transformDashboardmethodsspec-bridge/index.tsSpecBridge.test.ts+P1SpecBridge.test.ts; the class-orchestration test now asserts onlylist/formNet: +24 / −931.
Breaking change
Removes the public exports
bridgePage,bridgeDashboard, andSpecBridge#transformPage/#transformDashboard. No replacement — render pages and dashboards through their renderers directly. Shipped as a@object-ui/reactmajor (changeset included).Verification
pnpm --filter @object-ui/react type-check— green (after building upstream deps)SpecBridge.test/P1SpecBridge/FormViewSpecConformance) — 3 files, 57 tests passingRefs objectstack-ai/objectstack#1892, objectstack-ai/objectstack#1878.
🤖 Generated with Claude Code