Conversation
timweri
changed the title
timweri
commented
Feb 16, 2026
obelisk
reviewed
Feb 16, 2026
obelisk
approved these changes
Feb 16, 2026
obelisk
added a commit
that referenced
this pull request
Apr 30, 2026
* builds * Works but not good * More tested * Bump authentictor-rs * Remove x509-parser from piv management module * Clean up test * Clean up yk8 branch (#28) * Port x509/mod.rs * WIP PIV verification * Revert x509-parser -> x509-cert migration * Create nongeneric yk::provision variants * Add generate csr example * Resolve conflict * cargo * undo * Update API * First attempt at keytype * fmt * Remove macro * Fix test * Fix generate csr test fail * Minimize diff * Remove debug * New CTAP2 API * Check all PRs * Support AES * Use API to fetch mgm key algorithm * breaking yk.unlock * unbreak * unbreak * bump to 0.15.0 * Bump to yk9 * clean * copilot fix * Copilot fix --------- Co-authored-by: Mitchell Grenier <mitchell@confurious.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: The large diff is due to the inclusion of Cargo.lock.
Followed #27 and implemented our own type which implements KeyType, allowing us to avoid importing
p256andp384. However, I usedspkifor signature verification instead ofring.These tests work on:
Management key parsing
When we parse management key, we need to now know the algorithm. So calls like
unlocknow needs to also query the Yubikey for the algorithm before parsing the management key.