-
Notifications
You must be signed in to change notification settings - Fork 182
fix: add no-config legacy mode for external config management #404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pierluigilenoci
wants to merge
7
commits into
oauth2-proxy:main
Choose a base branch
from
pierluigilenoci:fix/no-config-mode-external-secrets
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
37b40ad
fix: add no-config legacy mode for external config management
pierluigilenoci 0b8ceb3
fix: bump chart version and fix documentation per Copilot review
pierluigilenoci 77b50d6
docs: clarify legacy-config mode resolution for alphaConfig override
pierluigilenoci 739cefd
chore: bump chart version to 10.5.0 (minor, new feature)
pierluigilenoci b601763
fix(ci): add minimum required args to no-config CI test
pierluigilenoci ca0992a
docs: update forceLegacyConfig description to cover no-config mode
pierluigilenoci 4294558
docs: replace ambiguous 'option 3' reference with 'no-config mode'
pierluigilenoci File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| # Test: no legacy config generation (external config management) | ||
| # Expected: No ConfigMap generated, no --config flag, no config volume mount. | ||
| # Use case: config managed externally via CSI SecretStore Driver or similar. | ||
| # | ||
| # Since no config file is mounted, the minimum required settings | ||
| # (email-domain, upstream) must be provided via extraArgs. | ||
|
|
||
| config: | ||
| forceLegacyConfig: false | ||
|
|
||
| extraArgs: | ||
| email-domain: "*" | ||
| upstream: "file:///dev/null" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.