Skip to content

feat: support templating in extraInitContainers #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jwoloch wants to merge 4 commits into
base: main
Choose a base branch
from
+4 −4
Open

feat: support templating in extraInitContainers #399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d1be81a
feat: support templating in extraInitContainers
jwoloch Mar 24, 2026
a5c3e6d
Merge branch 'main' into main
pierluigilenoci Mar 24, 2026
8c8a5d1
Merge branch 'main' into main
pierluigilenoci Mar 26, 2026
d82a400
Merge branch 'main' into main
pierluigilenoci Mar 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions helm/oauth2-proxy/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: oauth2-proxy
version: 10.4.2
version: 10.4.3
apiVersion: v2
appVersion: 7.15.1
home: https://oauth2-proxy.github.io/oauth2-proxy/
Expand Down Expand Up @@ -31,7 +31,7 @@ kubeVersion: ">=1.16.0-0"
annotations:
artifacthub.io/changes: |
- kind: changed
Copy link

Copilot AI Mar 29, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Artifact Hub changelog entry uses kind: changed, but this PR adds new functionality (templating support) rather than modifying existing behavior for default values. Consider using kind: added to better reflect the nature of the change in release notes.

Suggested change
- kind: changed
- kind: added

Copilot uses AI. Check for mistakes.
description: Bump OAuth2 Proxy image to v7.15.1
description: feat: support templating in extraInitContainers
Copy link

Copilot AI Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change adds templating support for the existing extraInitContainers value, but the user-facing docs don’t mention that extraInitContainers now supports tpl (unlike extraEnv, which is documented in the chart README). Please update the chart documentation (README and/or the values.yaml comments) to reflect the new templating behavior and any gotchas (e.g., {{ ... }} sequences will now be evaluated).

Suggested change
description: feat: support templating in extraInitContainers
description: feat: support templating in extraInitContainers (values are now rendered with tpl, so {{ ... }} sequences will be evaluated as Helm templates rather than treated as literal text)

Copilot uses AI. Check for mistakes.
links:
- name: GitHub PR
url: https://github.com/oauth2-proxy/manifests/pull/403
url: https://github.com/oauth2-proxy/manifests/pull/399
2 changes: 1 addition & 1 deletion helm/oauth2-proxy/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ spec:
{{- if or (and $redisEnabled .Values.initContainers.waitForRedis.enabled) .Values.extraInitContainers }}
initContainers:
{{- if .Values.extraInitContainers }}
{{- toYaml .Values.extraInitContainers | nindent 6 }}
{{- tpl (toYaml .Values.extraInitContainers) . | nindent 6 }}
{{- end }}
{{- if and $redisEnabled .Values.initContainers.waitForRedis.enabled }}
- name: wait-for-redis
Expand Down
Loading