Datastore authentication for workload identity#378
Open
RohanM wants to merge 1 commit intonytimes:mainfrom
Open
Datastore authentication for workload identity#378RohanM wants to merge 1 commit intonytimes:mainfrom
RohanM wants to merge 1 commit intonytimes:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Fix authentication compatibility for datastore when using workload identity rather than manual credentials.
Related Issue
N/A
Motivation and Context
When using workload identity,
getAuth()will return an object withoutemailorkeyfields. If we provide null values when initialising the datastore client, this breaks authentication:If instead we leave out any authentication details, the client will default to using the workload identity and successfully connect.
Checklist
npm run lintand updated code style accordinglynpm run testpasses