Conversation
ZevEisenberg
force-pushed
the
chore/zeveisenberg/fix-linting
branch
from
35b46cf to
7c5f3c9
Compare
mr-fixit
reviewed
Dec 2, 2020
Contributor
Author
|
Thinking the CocoaPods template project is too opinionated and hard to control, and we can simplify the whole thing by making our own non-CocoaPods project. That's the direction I'll probably go in this PR. See https://GitHub.com/Rightpoint/BonMot for an example of how this might look. |
mr-fixit
approved these changes
Dec 2, 2020
Contributor
mr-fixit
left a comment
mr-fixit
left a comment
There was a problem hiding this comment.
approved, but please also change this line in bootstrap
cd "$(dirname "$0")/../Examples"
Contributor
Author
|
I filed this bug with CocoaPods regarding the Carthage breakage. Going to work around it manually by making our own project file. https://github.com/CocoaPods/CocoaPods/issues/10266 |
mr-fixit
approved these changes
Dec 4, 2020
Contributor
mr-fixit
left a comment
mr-fixit
left a comment
There was a problem hiding this comment.
thanks for pursuing this!
Contributor
Author
|
I filed a CocoaPods bug on something that's making this trickier, but I think we can still work around it. |
ZevEisenberg
force-pushed
the
chore/zeveisenberg/fix-linting
branch
from
3a7a5a5 to
82b38a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some linting cleanup.
TODO: