Update CMakeLists.txt - fix issue missing libfzf.dll, expected in build, found in build/Release#143
Closed
lyoneel wants to merge 1 commit intonvim-telescope:mainfrom
Closed
Update CMakeLists.txt - fix issue missing libfzf.dll, expected in build, found in build/Release#143lyoneel wants to merge 1 commit intonvim-telescope:mainfrom
lyoneel wants to merge 1 commit intonvim-telescope:mainfrom
Conversation
Speficy explicitly the build output directory, without this change libfzf.dll will be created inside ./build/Release, and neovim plugin expects this file in ./build directory.
Contributor
|
Hi! I'm the original author of the CMakeLists.txt + presets file. If you use install(TARGETS ${PROJECT_NAME} DESTINATION ${CMAKE_BINARY_DIR})At the very bottom of the |
Contributor
|
included in #158 (thanks!) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the following configuration in windows using lazy.nvim and cmake:
{ 'nvim-telescope/telescope-fzf-native.nvim', build = 'cmake -S. -Bbuild -DCMAKE_BUILD_TYPE=Release && cmake --build build --config Release' }Neovim complains about a missing dll file in the build directory. I found that the dll file is compiled and is inside build/Release folder.
This fix specify explicitly the build output directory to be ./build directory.
This was tested on win10
NOTE: I didn't realize there were other PRs addressing the issue, I just fix by myself ASAP and copy my solution here.