Conversation
seanbudd
added
the
conceptApproved
updates: - [github.com/astral-sh/ruff-pre-commit: v0.14.5 → v0.14.10](astral-sh/ruff-pre-commit@v0.14.5...v0.14.10) - [github.com/astral-sh/uv-pre-commit: 0.9.11 → 0.9.21](astral-sh/uv-pre-commit@0.9.11...0.9.21) - [github.com/DavidAnson/markdownlint-cli2: v0.18.1 → v0.20.0](DavidAnson/markdownlint-cli2@v0.18.1...v0.20.0)
pre-commit-ci
bot
force-pushed
the
pre-commit-ci-update-config
branch
from
9b88052 to
952ae8f
Compare
| "uv==0.9.27", | ||
| ] | ||
| lint = [ | ||
| "ruff==0.14.5", | ||
| "ruff==0.14.14", |
There was a problem hiding this comment.
@SaschaCowley - please make sure to update changes for developers in changes.md
|
@SaschaCowley - this shouldn't have been merged, it introduced a tonne of linting errors with new markdown rules. Now precommit is failing on master and all PRs based on master https://results.pre-commit.ci/run/github/45885732/1769574878.GcVUsVfhSo2kLzR9V4iI_g |
|
Opened: #19522 |
### Reverts PR Reverts #19311 ### Issues fixed N/A ### Issues reopened N/a ### Reason for revert Introduced linting errors, forgot to update changes.md ### Can this PR be reimplemented? If so, what is required for the next attempt Linting errors need to be fixed
|
@seanbudd pre-commit CI is kind of useless if it failing doesn't count as checks failing |
|
@SaschaCowley - the commit you merged had a failing check: a1497b9. We just don't have branch protection rules set up for it. I'll ad them now |
Thanks. I am (now) aware that it had a failing check, but we either need to have all required checks required in branch protection rules, or disable the merge queue. Disabling the merge queue doesn't fully solve the problem anyway, because GitHub would still happily let you merge manually with failing checks - which aren't necessarily obvious when using a screen reader or GitHub CLI. |
|
Branch protection rules is where you define the required checks. I believe pre-commit was there before but it was possibly missed when setting it up. either way, it is there now as a required check. |
2 participants
updates: