[Cheng Tze Ning] iP - #67
Open
tzzzening wants to merge 38 commits into
Open
Conversation
ananda-lye
reviewed
Feb 4, 2020
ananda-lye
left a comment
ananda-lye
left a comment
There was a problem hiding this comment.
Not much violations, coding quality not bad :)
yolanmz
reviewed
Feb 9, 2020
yolanmz
left a comment
yolanmz
left a comment
There was a problem hiding this comment.
Overall, your code is easy to read except some conditional statements can be possibly simplified. All your best for your iP xD
| while (!userInput.equals("bye")) { | ||
| if (userInput.equals("list")) { | ||
| printTasks(); | ||
| } else if (userInput.length() > 4 && userInput.substring(0, 5).equals("done ")) { |
There was a problem hiding this comment.
Consider simplifying the conditional statement using startsWith. It is applicable to the rest of the conditions below.
Ex. else if(userInput.startsWith("done")
Author
There was a problem hiding this comment.
Thank you for your suggestion. I find it very efficient 👍 Will add it to my code later on.
Branch level 9
# Conflicts: # src/main/java/Command.java # src/main/java/Duke.java # src/main/java/Messages.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.