[Yang Chenglong] iP - #46
Open
A11riseforme wants to merge 99 commits into
Open
Conversation
Add toolVersion block in to Gradle code sample to prevent errors.
Change file mode on `gradle` to be executable (nus-cs2113-AY1920S2#9)
Gradle defaults to an empty stdin which results in runtime exceptions when attempting to read from `System.in`. Let's add some sensible defaults for students who may still need to work with the standard input stream.
Add configuration for console applications
The OpenJFX plugin expects applications to be modular and bundled with jlink, resulting in fat jars that are not cross-platform. Let's manually include the required dependencies so that shadow can package them properly.
yuxianglim
reviewed
Feb 4, 2020
| @@ -0,0 +1,15 @@ | |||
| public class Deadline extends Task { | |||
| protected String byTime; | |||
| protected String typeIcon; | |||
There was a problem hiding this comment.
Maybe you could remove the additional whitespace for line 3
| private static final String LOGO = " __ __ _ __ \n" + | ||
| " /\\ /_ /_ | (_) / _| \n" + | ||
| " / \\ | || |_ __ _ ___ ___| |_ ___ _ __ _ __ ___ ___ \n" + | ||
| " / /\\ \\ | || | '__| / __|/ _ \\ _/ _ \\| '__| '_ ` _ \\ / _ \\\n" + |
Comment on lines
+4
to
+11
| private static final String LINE_DIVIDER = " ____________________________________________________________"; | ||
| private static final String LIST_TASKS_PROMPT = " Here are the tasks in your list:"; | ||
| private static final String DONE_TASKS_PROMPT = " Nice! I've marked this task as done:"; | ||
| private static final String ADD_TASKS_PROMPT = " Got it. I've added this task:"; | ||
| private static final String ADD_TASKS_POST_PROMPT = " Now you have %d tasks in the list.\n"; | ||
| private static final String LIST_SINGLE_TASK_MESSAGE = " %d.%s\n"; | ||
| private static final String ADD_SINGLE_TASK_MESSAGE = " %s\n"; | ||
| private static final String DONE_SINGLE_TASK_MESSAGE = " %s\n"; |
There was a problem hiding this comment.
Perhaps you can consider consolidating all the magic numbers/strings into a .class file
Comment on lines
+4
to
+5
| protected static final String yesIcon = "[\u2713]"; | ||
| protected static final String noIcon = "[\u2718]"; |
There was a problem hiding this comment.
Can consider consolidating these into a .class file and import the file when needed
| @@ -0,0 +1,15 @@ | |||
| public class Event extends Task { | |||
| protected String time; | |||
| protected String typeIcon; | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.