Add early exit for argsort if array is already sorted#197
Merged
sterrettm2 merged 1 commit intonumpy:mainfrom Apr 15, 2025
Merged
Add early exit for argsort if array is already sorted#197sterrettm2 merged 1 commit intonumpy:mainfrom
sterrettm2 merged 1 commit intonumpy:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relative to scalar argsort, SIMD argsort is slower for ordered/sorted arrays. An easy fix is to detect sorted arrays and exit early. This doesn't add much overhead to random arrays but does slightly regress on uniform/constant arrays. But perhaps that trade off is worth it since argsort is fairly faster than scalar argsort for uniform/constant arrays. Benchmarks on AVX2: