Closed
Conversation
sterrettm2
suggested changes
Jun 5, 2025
Contributor
sterrettm2
left a comment
sterrettm2
left a comment
There was a problem hiding this comment.
This is mostly good, I just have a few issues that need addressing:
Needs to test ASAN for both avx2 and avx512 codepaths
Needs to have some smaller test sizes for OpenMP tests to verify the non-threaded case works correctly (probably including 0 given past issues).
We need to be sure the non-native fp16 code is tested, should be good if you just keep the Run ICL fp16 tests test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mainly two changes: