[#1124] Add preliminary DICE certificate support#1125
Open
iadgovuser59 wants to merge 2 commits intomainfrom
Open
[#1124] Add preliminary DICE certificate support#1125iadgovuser59 wants to merge 2 commits intomainfrom
iadgovuser59 wants to merge 2 commits intomainfrom
Conversation
iadgovuser59
changed the title
ThatSilentCoder
requested changes
Mar 5, 2026
Collaborator
ThatSilentCoder
left a comment
ThatSilentCoder
left a comment
There was a problem hiding this comment.
I uploaded the test certificates and everything worked well!
I did have some comments about the structure of the classes/enums that were used to represent these new certificate attributes. And I made a comment about whether or not the table that represents the DICE INFO should be available to be seen at all times or it should be hidden until the user clicks on the DICE INFO header?
...ava/hirs/attestationca/persist/entity/userdefined/certificate/attributes/DiceAttributes.java
Outdated
Show resolved
Hide resolved
...ava/hirs/attestationca/persist/entity/userdefined/certificate/attributes/DiceAttributes.java
Outdated
Show resolved
Hide resolved
...ava/hirs/attestationca/persist/entity/userdefined/certificate/attributes/DiceAttributes.java
Outdated
Show resolved
Hide resolved
...ava/hirs/attestationca/persist/entity/userdefined/certificate/attributes/DiceAttributes.java
Outdated
Show resolved
Hide resolved
| * @return the corresponding DiceKeyPurpose, or OTHER if not recognized | ||
| */ | ||
| private static DiceKeyPurpose toDiceKeyPurpose(final String oid) { | ||
| if (OID_TCG_DICE_KP_IDENTITY_INIT.equals(oid)) { |
Collaborator
There was a problem hiding this comment.
You could probably replace this with a switch.
| <a role="button" data-bs-toggle="collapse" class="collapsed" | ||
| href="#diceInfoInner" aria-expanded="true" data-bs-placement="top" | ||
| aria-controls="diceInfoInner"> | ||
| DICE Info ▼ |
Collaborator
There was a problem hiding this comment.
Seeing as the DICE Info table is pretty small, do you think this should be a collapsible row or a table that can be displayed at all times?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds preliminary support for DICE certificate parsing, which is available through the IDevID certificate page. The additional fields will be displayed via the Certificate Details page, which includes a "DICE Info" section if said fields are present.
To test: upload a DICE-supported certificate via the IDevID Certificates page, and note present fields (as seen in the screenshot below).
Closes #1124.