samples: bluetooth: update minimum key size in security parameters - #845
Merged
Conversation
|
You can find the documentation preview for this PR here. |
eivindj-nordic
approved these changes
Aug 21, 2026
b-gent
requested changes
Aug 27, 2026
Update the minimum key size of the Bluetooth LE GAP security parameters to 16 bytes in the applicable bluetooth samples. Want safe by default. Signed-off-by: Andreas Moltumyr <andreas.moltumyr@nordicsemi.no>
anhmolt
force-pushed
the
increase-min-key-size
branch
from
August 27, 2026 10:41
39d08bc to
ae6c192
Compare
b-gent
approved these changes
Aug 27, 2026
seko-nordic
reviewed
Aug 28, 2026
Contributor
There was a problem hiding this comment.
where is SEC_PARAM_MIN_KEY_SIZE defined? I cannot find it. Should we change to 16 here as well?
Contributor
Author
There was a problem hiding this comment.
Thanks for taking a look!
SEC_PARAM_MIN_KEY_SIZE and SEC_PARAM_MAX_KEY_SIZE was probably meant as a wildcard. I agree it makes sense to change it to 16. Updated.
Update the minimum key size of the Bluetooth LE GAP security parameters in peer manager documentation. Signed-off-by: Andreas Moltumyr <andreas.moltumyr@nordicsemi.no>
anhmolt
force-pushed
the
increase-min-key-size
branch
from
August 28, 2026 08:13
ae6c192 to
b00a6e9
Compare
seko-nordic
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the minimum key size of the Bluetooth LE GAP security parameters to 16 bytes in the applicable bluetooth samples.
Reason: "safe by default".