sample: bluetooth: Document Peer Manager section of samples - #823
Merged
eivindj-nordic merged 1 commit intoAug 31, 2026
Merged
Conversation
github-actions
Bot
added
changelog-entry-required
PizzaAllTheWay
force-pushed
the
peer-manager-sample-doc
branch
from
July 27, 2026 15:13
030bddc to
fecdcb7
Compare
PizzaAllTheWay
marked this pull request as ready for review
July 27, 2026 15:13
|
You can find the documentation preview for this PR here. |
Contributor
|
Commit title prefix should be |
PizzaAllTheWay
force-pushed
the
peer-manager-sample-doc
branch
from
July 28, 2026 07:38
fecdcb7 to
083d9a2
Compare
PizzaAllTheWay
force-pushed
the
peer-manager-sample-doc
branch
from
July 28, 2026 08:23
083d9a2 to
bfc64ca
Compare
eivindj-nordic
approved these changes
Jul 28, 2026
PizzaAllTheWay
force-pushed
the
peer-manager-sample-doc
branch
from
July 28, 2026 13:53
bfc64ca to
115316f
Compare
eivindj-nordic
removed
the
changelog-entry-required
b-gent
approved these changes
Aug 14, 2026
b-gent
approved these changes
Aug 14, 2026
b-gent
left a comment
b-gent
left a comment
Contributor
There was a problem hiding this comment.
approving, pls fix the typo (appears 6 times)
PizzaAllTheWay
force-pushed
the
peer-manager-sample-doc
branch
from
August 14, 2026 13:27
115316f to
0018054
Compare
github-actions
Bot
added
the
changelog-entry-required
PizzaAllTheWay
force-pushed
the
peer-manager-sample-doc
branch
from
August 14, 2026 13:27
0018054 to
506066f
Compare
anhmolt
requested changes
Aug 14, 2026
anhmolt
left a comment
anhmolt
left a comment
Contributor
There was a problem hiding this comment.
I think we need better precision when explaining the security parameters. There is a slight difference to how they should be understood for a central and a peripheral.
See comments. They (probably) apply for all the sample README's in this PR.
PizzaAllTheWay
force-pushed
the
peer-manager-sample-doc
branch
from
August 17, 2026 09:54
506066f to
e2ba6dd
Compare
anhmolt
reviewed
Aug 18, 2026
PizzaAllTheWay
force-pushed
the
peer-manager-sample-doc
branch
2 times, most recently
from
August 18, 2026 17:02
800ee12 to
7ded0ab
Compare
PizzaAllTheWay
force-pushed
the
peer-manager-sample-doc
branch
from
August 19, 2026 08:16
7ded0ab to
014313a
Compare
anhmolt
reviewed
Aug 19, 2026
anhmolt
left a comment
anhmolt
left a comment
Contributor
There was a problem hiding this comment.
Looks good! Some follow up comments.
PizzaAllTheWay
force-pushed
the
peer-manager-sample-doc
branch
from
August 19, 2026 15:01
014313a to
2f09e13
Compare
eivindj-nordic
removed
the
changelog-entry-required
anhmolt
reviewed
Aug 20, 2026
Add a short Security chapter to the README.rst of each relevant Bluetooth sample that integrates Peer Manager, describing the configured pairing/bonding parameters and the security requirements of the sample's BLE services. Samples with peer manager documentation: - ble_bms - ble_cgms - ble_hids_keyboard - ble_hids_mouse - ble_hrs - ble_hrs_central - peripheral_nfc_pairing Signed-off-by: Martynas Smilingis <martynas.smilingis@nordicsemi.no>
anhmolt
force-pushed
the
peer-manager-sample-doc
branch
from
August 26, 2026 11:49
2f09e13 to
dae4cbf
Compare
github-actions
Bot
added
the
changelog-entry-required
anhmolt
approved these changes
Aug 26, 2026
marenges
approved these changes
Aug 31, 2026
eivindj-nordic
removed
the
changelog-entry-required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a short "Security" chapter to the
README.rstof each relevant Bluetooth sample that integrates Peer Manager,describing the configured pairing/bonding parameters and the security requirements of the sample's BLE services.
Samples with peer manager documentation:
ble_bmsble_cgmsble_hids_keyboardble_hids_mouseble_hrsble_hrs_centralperipheral_nfc_pairing