Add functionality to query card without board id#81
Open
J0N3X wants to merge 1 commit intonorberteder:mainfrom
Open
Add functionality to query card without board id#81J0N3X wants to merge 1 commit intonorberteder:mainfrom
J0N3X wants to merge 1 commit intonorberteder:mainfrom
Conversation
You can't allways assume we have the board id of a single card. Trello supports this kind of functionality, and i find it very difficulty to understand why shouldn't this aswell. New function "getCardWithoutBoardId" only takes cardId + callback, for convinience.
Author
|
Okay, hold up. If someone else has fucked up build, we cant get anything in? |
Contributor
|
The test suite only fails for Node.js version 4.x which has reached end of life. I've removed support for that old version of Node.js in pull request #83 and if it is merged and you update your branch to include it then the tests should pass again. |
Owner
|
@sinisterstuf : Thanks for you PR, I've merged that already. @J0N3X : Can you please provide some tests? Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You can't allways assume we have the board id of a single card.
Trello supports this kind of functionality, and i find it very
difficulty to understand why shouldn't this aswell. New function
"getCardWithoutBoardId" only takes cardId + callback, for convinience.