[5.17 backport] kms: support key rotation for vault#1794
Open
jackyalbo wants to merge 5 commits intonoobaa:5.17from
Open
[5.17 backport] kms: support key rotation for vault#1794jackyalbo wants to merge 5 commits intonoobaa:5.17from
jackyalbo wants to merge 5 commits intonoobaa:5.17from
Conversation
Signed-off-by: Praveen M <m.praveen@ibm.com> (cherry picked from commit d2a7617)
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: liranmauda <liran.mauda@gmail.com> (cherry picked from commit 8deec77)
- Removing False positive verification of KMS condition status Init The Init condition status is, in most cases, a state that is short in time, and the tests are missing the timing, hence failing. We do not need this case as corev1.ConditionStatus = "Sync" will never happen if Init did not, and we will fail there. Signed-off-by: liranmauda <liran.mauda@gmail.com> (cherry picked from commit de03454)
jackyalbo
force-pushed
the
jacky-5_17-backport
branch
from
1794f6b to
c64b442
Compare
Signed-off-by: jackyalbo <jacky.albo@gmail.com> (cherry picked from commit 18b2405)
Signed-off-by: jackyalbo <jacky.albo@gmail.com>
jackyalbo
force-pushed
the
jacky-5_17-backport
branch
from
8af32d9 to
f7f131c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit d2a7617)
Explain the changes
Issues: Fixed #xxx / Gap #xxx
Testing Instructions: