Move click/tap events to onClick handler to fix bug with double tapping on mobile Chrome#7310
Open
broox wants to merge 2 commits intonolimits4web:masterfrom
Open
Move click/tap events to onClick handler to fix bug with double tapping on mobile Chrome#7310broox wants to merge 2 commits intonolimits4web:masterfrom
broox wants to merge 2 commits intonolimits4web:masterfrom
Conversation
broox
force-pushed
the
mobile-chrome-doubletap-fix
branch
4 times, most recently
from
d6af877 to
c0adeb0
Compare
|
Why hasn't this been merged yet? Is there a workaround? @nolimits4web |
m345054
approved these changes
Jul 26, 2024
Contributor
Author
|
hi @nolimits4web, do you have concerns with this implementation? anything i can do to help? |
siimsams
approved these changes
Dec 5, 2024
…ng on mobile chrome.
broox
force-pushed
the
mobile-chrome-doubletap-fix
branch
from
c0adeb0 to
85059be
Compare
Contributor
Author
|
FWIW - the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was an issue in which double tap events were not being emitted on mobile Chrome.
On mobile Chrome, the second touch event was not being emitted appropriately, which resulted in touch times being much longer than 300ms.
The
clickevent is being emitted on all browsers, as expected. This change moves tap/click events to theonClickhandler, which I think makes more sense. This change fixes the bug for me.Closes: #7309