Fix CodeQL security vulnerabilities and lint issues#61
Merged
Conversation
## Security Fixes | Vulnerability | Severity | Location | Fix | |--------------|----------|----------|-----| | SSRF | Critical | crawler/master.py | Added `is_safe_url()` validation | | XML Bomb | High | crawler/master.py | Replaced `xml.etree` with `defusedxml` | | Path Injection | High | frontend/chat-app/bin/nlweb-chat.mjs | Use `resolve()` with proper boundary check | | Double Escaping | High | ChatSearch.tsx | Move `&` decoding to last | | Clear-text Logging | High | create_test_user.py | Mask API keys in output | | Stack Trace Exposure | Medium | api.py, SSE interfaces | Return generic error messages | | Workflow Permissions | Medium | check.yml | Add explicit `permissions: contents: read` | 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Resolve conflicts in SSE handlers while preserving both: - Security fix: use logger.exception() instead of exposing stack traces - Main branch improvement: handle mid-stream errors gracefully 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Security Fixes
is_safe_url()validationxml.etreewithdefusedxmlresolve()with proper boundary check&decoding to lastpermissions: contents: readTest plan
make checkin ask_api, crawler, and frontend directories🤖 Generated with Claude Code