neovim: load the wrapper generated lua#8734
Draft
teto wants to merge 4 commits intonix-community:masterfrom
Draft
neovim: load the wrapper generated lua#8734teto wants to merge 4 commits intonix-community:masterfrom
teto wants to merge 4 commits intonix-community:masterfrom
Conversation
now that home-manager always generates an init.lua we can take the wrapper output instead of reimplemnting stuff in HM (notwithstanding rtp changes that are not needed in HM). This is necessary to keep the provider configuration available after this change NixOS/nixpkgs#487390
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Logical follow up once NixOS/nixpkgs#487390 is merged.
This means an init.lua is now always generated which will probably break a lot more configs than the recent neovim-related changes. I would like to avoid adding yet a new option just to keep the old behavior as we would get 2 different ways to launch neovim, making the behavior and testing different in an obscure way for the user.
The manual user solution to update their config would be the same as for previous PR:
5786e42
At the same time, I fear it breaks too many configs for us to ignore to here is what I came up with:
To avoid creating a new option while keeping current behavior:
Ideally I would like to get rid of 1 (to avoid special casing HM, compared to nixpkgs neovim wrapper), maybe by displaying some warning to user on how to update their config.
In the short term, if I could get 2 running on my machine, it would be great. Would make neovim work as on other distrib, and let me hack on neovim C code without further nix hacks.
Checklist
Change is backwards compatible.
Code formatted with
nix fmtornix-shell -p treefmt nixfmt deadnix keep-sorted nixf-diagnose --run treefmt.Code tested through
nix run .#tests -- test-allornix-shell --pure tests -A run.all.Test cases updated/added. See example.
Commit messages are formatted like
See CONTRIBUTING for more information and recent commit messages for examples.
If this PR adds a new module
If this PR adds an exciting new feature or contains a breaking change.