Skip to content

Support cert auth#1

Open
nitzpo wants to merge 5 commits intomainfrom
support-cert-auth
Open

Support cert auth#1
nitzpo wants to merge 5 commits intomainfrom
support-cert-auth

Conversation

@nitzpo
Copy link
Copy Markdown
Owner

@nitzpo nitzpo commented Jul 28, 2025

No description provided.

nitzpo and others added 5 commits July 14, 2025 10:25
Fix readme example

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Nitzan Pomerantz <9297302+nitzpo@users.noreply.github.com>
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @nitzpo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant enhancement by adding support for certificate-based authentication to the Lokka MCP server. This new capability allows for more flexible and secure app-only authentication scenarios using PEM-encoded client certificates, expanding the range of deployment options.

Highlights

  • New Authentication Method: I've implemented support for certificate-based authentication, leveraging the ClientCertificateCredential from the @azure/identity library. This introduces a new, secure way for app-only authentication.
  • Configuration and Usage: New environment variables (CERTIFICATE_PATH, CERTIFICATE_PASSWORD, USE_CERTIFICATE) have been added to configure certificate authentication. The README.md has been updated with clear instructions and an openssl command for converting PFX certificates to PEM format.
  • Authentication Mode Enforcement: The application's startup logic now includes a check to ensure that only one authentication mode (Client Provided Token, Interactive, or the new Certificate mode) is enabled at a time, preventing potential configuration conflicts.
  • Documentation and Versioning: The README.md has been updated to reflect the new authentication method, re-indexing the existing methods. The project version has also been bumped to 0.2.1 in package.json and package-lock.json.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments or fill out our survey to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for certificate-based authentication, a valuable addition to the existing authentication methods. The implementation is well-done, correctly using @azure/identity for the new auth flow and adding validation to prevent misconfiguration with multiple authentication modes enabled. The documentation has also been updated accordingly.

Comment thread src/mcp/README.md
![How does Lokka work?](https://github.com/merill/lokka/blob/main/website/docs/assets/how-does-lokka-mcp-server-work.png?raw=true)

## Authentication Methods *(Enhanced in v0.2.0)*
## Authentication Methods *(Enhanced in v0.2)*
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To maintain consistency with the package version (0.2.1) and the contributors section, it would be clearer to specify the exact version of the enhancement. The current change from v0.2.0 to v0.2 is a bit ambiguous.

Suggested change
## Authentication Methods *(Enhanced in v0.2)*
## Authentication Methods *(Enhanced in v0.2.1)*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant