Asynchronous dowloads of dependencies.#938
Draft
bobeff wants to merge 2 commits intonim-lang:masterfrom
Draft
Conversation
This reverts commit ad17ab1.
This commit implements parallel downloads of free not locked dependencies. It is currently buggy. There are two problems: - Stall when downloading dependencies. - Error: "No handles or timers registered in dispatcher." in "do not install single dependency multiple times (nim-lang#678)" test.
yyoncho
pushed a commit
to yyoncho/nimble
that referenced
this pull request
Aug 23, 2022
- implementation of async download based on chronos asyncproc - the PR is based on nim-lang#938
yyoncho
pushed a commit
to yyoncho/nimble
that referenced
this pull request
Aug 23, 2022
- implementation of async download based on chronos asyncproc - the PR is based on nim-lang#938
yyoncho
pushed a commit
to yyoncho/nimble
that referenced
this pull request
Aug 24, 2022
- implementation of async download based on chronos asyncproc - the PR is based on nim-lang#938
yyoncho
pushed a commit
to yyoncho/nimble
that referenced
this pull request
Aug 24, 2022
- implementation of async download based on chronos asyncproc - the PR is based on nim-lang#938
yyoncho
pushed a commit
to yyoncho/nimble
that referenced
this pull request
Aug 24, 2022
- implementation of async download based on chronos asyncproc - the PR is based on nim-lang#938
yyoncho
pushed a commit
to yyoncho/nimble
that referenced
this pull request
Aug 24, 2022
- implementation of async download based on chronos asyncproc - the PR is based on nim-lang#938
yyoncho
pushed a commit
to yyoncho/nimble
that referenced
this pull request
Aug 24, 2022
- implementation of async download based on chronos asyncproc - the PR is based on nim-lang#938
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is a work in progress intended to be a starting point for those who want to finish this feature. Currently, it is not working stably and random crashes, stalls, and other misbehaviors are observed caused by bugs in the
asynctoolslibrary or in the Nim's standard libraryasyncdispatchmodule. Also, is left to be implemented a limit of maximum async downloads when downloading free (not locked) dependencies.