Feat: Add package name to no tagged releases warning#1447
Open
MorganaFuture wants to merge 1 commit intonim-lang:masterfrom
Open
Feat: Add package name to no tagged releases warning#1447MorganaFuture wants to merge 1 commit intonim-lang:masterfrom
MorganaFuture wants to merge 1 commit intonim-lang:masterfrom
Conversation
Collaborator
|
This approach is quite fragile i.e. |
Contributor
|
If the canonical name is not available yet, I think it's fine to print the url / whatever was given to |
Collaborator
|
The name is available though as the package is supposed to be cloned already Edit: you are right. Looked at a bad spot in the code. The right thing to do is to print the url |
6afa2aa to
4b8626a
Compare
Author
|
Hi @jmgomez @arnetheduck I rewrote the PR to show the URL instead of the name. I also used nph for formatting, as I understand it, it is not mandatory in the project?) Is it necessary to revert everything back? |
Member
IMHO, yes, as now the diff contains many random changes and worse, the original formatting seems better too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link: Issues 1432