Allow local paths to be used for package specification.#1241
Open
panno8M wants to merge 5 commits intonim-lang:masterfrom
Open
Allow local paths to be used for package specification.#1241panno8M wants to merge 5 commits intonim-lang:masterfrom
panno8M wants to merge 5 commits intonim-lang:masterfrom
Conversation
When developing local dependent packages, the unmodified implementation should use ```console nimble develop file:///absolute/path/to/package ``` but this is not suitable for development since it will be cloned into a subdirectory. If the package is a local package, it is easier to handle it as is without cloning. With this change, ```console nimble develop file:///absolute/path/to/package --withDependencies ``` would change nimble.develop as follows: ```diff "dependencies": [ ... + "absolute/path/to/package" ] ```
```console nimble develop file:///absolute/path/to/package ``` is still a bit cumbersome and confusing for those not familiar with uri. ```console nimble develop /absolute/path/to/package ``` directory exists, the preferred UX would be to interpret this implicitly as file://.
xTrayambak
approved these changes
Aug 13, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same content as PR #1237. I reworked it because I accidentally committed an extra one.
What this PR will allow to do
--withDependencieswhennimble develop.This reduces confusion like #1134 and #1124.
Case Study
Install local package
Develop local package
Things to consider
Maybe we should have an option to clone local packages or not.