Skip to content

test i386 #25520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ringabout wants to merge 13 commits into
base: devel
Choose a base branch
from
+291 −221
Draft

test i386 #25520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
b2e6390
test i386
ringabout Feb 16, 2026
a54f713
progress
ringabout Feb 16, 2026
802cf3d
i386
ringabout Feb 16, 2026
1e14855
progress
ringabout Feb 16, 2026
8ec10dc
accelerate
ringabout Feb 16, 2026
503a95b
allow all branches
ringabout Feb 16, 2026
decd9b3
test
ringabout Feb 16, 2026
dacd72a
try
ringabout Feb 16, 2026
a4cf69c
progress
ringabout Feb 16, 2026
c52568e
progress
ringabout Feb 16, 2026
ac13131
revert
ringabout Feb 16, 2026
31f188d
Refactor alignment checks in gc.nim
ringabout Feb 17, 2026
920814e
progress
ringabout Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/bisects.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
# See https://github.com/juancarlospaco/nimrun-action/issues/3#issuecomment-1607344901
name: issue comments bisects
on:
issue_comment:
types: created
workflow_dispatch:
Copy link

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow has been changed from issue_comment trigger to workflow_dispatch. However, the job condition on line 9 checks for github.event_name == 'issue_comment', which will never be true when triggered manually via workflow_dispatch. This effectively disables the bisects functionality entirely.

Suggested change
workflow_dispatch:
workflow_dispatch:
issue_comment:
types: [created]

Copilot uses AI. Check for mistakes.

jobs:
bisects:
Expand Down
29 changes: 1 addition & 28 deletions .github/workflows/ci_docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,33 +1,6 @@
name: Nim Docs CI
on:
Copy link

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Docs CI workflow has been changed from running automatically on pushes and pull requests to only manual triggering via workflow_dispatch. This removes automatic documentation validation on code changes, which could allow documentation issues to go undetected. The change appears unrelated to testing i386 support.

Suggested change
on:
on:
push:
branches:
- devel
pull_request:
branches:
- devel

Copilot uses AI. Check for mistakes.
push:
paths:
- 'compiler/**.nim'
- 'config/nimdoc.cfg'
- 'doc/**.rst'
- 'doc/**.md'
- 'doc/nimdoc.css'
- 'lib/**.nim'
- 'nimdoc/testproject/expected/testproject.html'
- 'tools/dochack/dochack.nim'
- 'tools/kochdocs.nim'
- '.github/workflows/ci_docs.yml'
- 'koch.nim'

pull_request:
# Run only on changes on these files.
paths:
- 'compiler/**.nim'
- 'config/nimdoc.cfg'
- 'doc/**.rst'
- 'doc/**.md'
- 'doc/nimdoc.css'
- 'lib/**.nim'
- 'nimdoc/testproject/expected/testproject.html'
- 'tools/dochack/dochack.nim'
- 'tools/kochdocs.nim'
- '.github/workflows/ci_docs.yml'
- 'koch.nim'
workflow_dispatch:

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
Copy link

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The concurrency group references github.event.pull_request.number, but the workflow trigger has been changed to workflow_dispatch only. This will result in an undefined/empty value for the pull request number, potentially causing issues with concurrency control.

Suggested change
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
group: ${{ github.workflow }}-${{ github.ref }}

Copilot uses AI. Check for mistakes.
Expand Down
99 changes: 99 additions & 0 deletions .github/workflows/ci_i386_linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,99 @@
name: i386 Linux CI

on:
pull_request:
branches:
- '*'
workflow_dispatch:


jobs:
build:
strategy:
fail-fast: false
max-parallel: 20
matrix:
branch: [devel]
target:
- os: linux
cpu: i386
nim_branch: devel
include:
- target:
os: linux
builder: ubuntu-24.04

name: '${{ matrix.target.os }}-${{ matrix.target.cpu }}-nim-${{ matrix.target.nim_branch }} (${{ matrix.branch }})'
runs-on: ${{ matrix.builder }}
env:
NIM_DIR: nim-${{ matrix.target.nim_branch }}-${{ matrix.target.cpu }}
NIM_BRANCH: ${{ matrix.target.nim_branch }}
NIM_ARCH: ${{ matrix.target.cpu }}
steps:
- name: set `core.autocrlf` to false
run: |
git config --global core.autocrlf false
git config --global init.defaultBranch master

- name: Checkout
uses: actions/checkout@v6
with:
submodules: false

- name: Install dependencies (Linux i386)
if: runner.os == 'Linux' && matrix.target.cpu == 'i386'
working-directory: ${{ github.workspace }}
run: |
sudo dpkg --add-architecture i386
sudo apt-get update -qq
sudo DEBIAN_FRONTEND='noninteractive' apt-get install \
--no-install-recommends -yq gcc-multilib g++-multilib \
libssl-dev:i386

mkdir -p external/bin
cat << EOF > external/bin/gcc
#!/bin/bash

exec $(which gcc) -m32 "\$@"
EOF

cat << EOF > external/bin/g++
#!/bin/bash

exec $(which g++) -m32 "\$@"
EOF

chmod 755 external/bin/gcc external/bin/g++

echo "$PWD/external/bin" >> "${GITHUB_PATH}"

- name: Add repo bin to PATH
run: echo "${GITHUB_WORKSPACE}/bin" >> ${GITHUB_PATH}

- name: Setup Nim
uses: alaviss/setup-nim@0.1.1
with:
path: 'nim'
version: ${{ matrix.target.nim_branch }}
architecture: ${{ matrix.target.cpu }}

# - name: Build koch using existing nim
# run: |
# nim c koch.nim

# - name: Boot the compiler from the checked-out commit
# shell: bash
# run: |
# ./koch boot -d:release

# - name: Show nim version and system info
# run: |
# bin/nim -v || true
# uname -a || true

- name: Run talign test (i386)
shell: bash
run: |
set -euo pipefail
export PATH="${GITHUB_WORKSPACE}/bin:$PATH"
nim c -r --lib:lib --mm:refc -d:useGcAssert -d:useSysAssert tests/align/talign.nim
9 changes: 1 addition & 8 deletions .github/workflows/ci_packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,6 @@
name: Packages CI
on:
Copy link

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Packages CI workflow has been changed from automatically running on pull requests and pushes to specific branches to only running manually via workflow_dispatch. This disables automatic package testing on PRs and branch pushes. If the intention is to test i386 support, this change appears unrelated and would significantly reduce CI coverage.

Suggested change
on:
on:
push:
branches:
- master
- devel
pull_request:
branches:
- master
- devel

Copilot uses AI. Check for mistakes.
pull_request:
push:
branches:
- 'devel'
- 'version-2-2'
- 'version-2-0'
- 'version-1-6'
- 'version-1-2'
workflow_dispatch:
Copy link

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR title is "test i386" which suggests the intent is to test i386 support. However, the changes disable nearly all existing CI workflows (Azure Pipelines, packages CI, docs CI, bisects, stale PR management, and publish CI) by either commenting them out or changing them to manual-only triggers. Only the new i386 workflow would run automatically. This appears to be a testing/development branch that shouldn't be merged as-is, as it would effectively disable the project's entire CI infrastructure except for a single i386 test.

Copilot uses AI. Check for mistakes.

concurrency:
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
Copy link

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The concurrency group references github.event.pull_request.number, but the workflow trigger has been changed to workflow_dispatch only, which doesn't have a pull_request event. This will cause the concurrency group to have an undefined/empty value for the pull request number when triggered manually.

Suggested change
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
group: ${{ github.workflow }}-${{ github.ref }}

Copilot uses AI. Check for mistakes.
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/ci_publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
name: Tracking orc-booting compiler memory usage

on:
pull_request_target:
types: [closed]
workflow_dispatch:


Comment on lines 5 to 6
Copy link

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow has been changed from pull_request_target trigger to workflow_dispatch. However, the job condition on line 9 checks if github.event.pull_request.merged == true, which will never be satisfied when the workflow is triggered manually. This effectively disables the memory tracking workflow entirely.

Suggested change
pull_request_target:
types:
- closed

Copilot uses AI. Check for mistakes.
jobs:
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/stale.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,7 @@
name: Stale pull requests

on:
Copy link

Copilot AI Feb 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The scheduled trigger for the stale PR workflow has been replaced with workflow_dispatch (manual trigger only). This means stale PRs will no longer be automatically marked or closed unless someone manually triggers this workflow. If the intention is to test i386 support, this change appears unrelated and should likely be reverted to maintain automated stale PR management.

Suggested change
on:
on:
schedule:
- cron: "0 0 * * *"

Copilot uses AI. Check for mistakes.
schedule:
- cron: '0 0 * * *' # Midnight.
workflow_dispatch:

jobs:
stale:
Expand Down
Loading