Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new consideration flag to signature hashing to normalize array index range handling, aiming to make array types hash more consistently (per #25475).
Changes:
- Introduces a new
ConsiderFlagvalue:CoIgnoreRangeInarray. - Updates
hashTypefortyRangeto support hashing range length (instead of exact bounds) when the new flag is present. - Updates
hashTypefortyArrayto pass the new flag when hashing the array index type.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #25475
sigmatch treats array compatibility by element type + length, not by the index (range) type. Perhaps backend should do the same check