Skip to content

Dedicated search view, explore places filter, Gird border - #204

Merged
nicx17 merged 8 commits into
mainfrom
feature/sidebar-search
Aug 30, 2026
Merged

Dedicated search view, explore places filter, Gird border#204
nicx17 merged 8 commits into
mainfrom
feature/sidebar-search

Conversation

@nicx17

@nicx17 nicx17 commented Aug 10, 2026

Copy link
Copy Markdown
Owner

Changes

  • Search form as persistent Revealer: No longer a separate content_stack page. Stays visible above the grid while results load, preserving the user's query.
  • 360px width compatibility: Vertical stacking, 8px margins, 6px filter spacing. New compact masonry tier for phone-sized screens.
  • Explore filter searches places: Filter entry now matches both people names and place city names.
  • Compact filter toggle: Collapsible filters with action buttons on a single row.
  • Configurable masonry grid border: Adjustable border width (0-50px, step 0.1) and custom border colour via a colour picker in Settings > Library View. Borders appear uniformly on all four edges and between tiles. Auto-saved on change.
  • Code quality refactoring: Extracted search filter builders into search_filters.rs and introduced FilterWidgets struct to reduce search_view.rs below Codacy complexity limits.
  • Fix clippy/SonarCloud warnings: Replace wildcard imports with explicit imports, use method references instead of closures, box oo7::Error in keyring closures.
  • Missing API key diagnostics: Log warnings at startup when server URL is configured but no API key is found.
  • Cleanup: Remove unused filters.rs.

- Search form is now a Revealer above content_stack (no more alt view)
- Search bar stays visible with query while results load in grid
- Explore filter searches both people and places
- Compact layout for 360px width compatibility
- Box oo7::Error to fix clippy result_large_err
- Add startup warning when API key is missing but server is configured
- Remove unused filters.rs
@nicx17 nicx17 added the enhancement New feature or request label Aug 10, 2026
@nicx17 nicx17 self-assigned this Aug 10, 2026
@nicx17 nicx17 added the bug Something isn't working label Aug 10, 2026
@codacy-production

codacy-production Bot commented Aug 10, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@nicx17
nicx17 force-pushed the feature/sidebar-search branch from 4271f1c to 280b689 Compare August 29, 2026 07:32
nicx17 added 5 commits August 29, 2026 13:19
- Fix Codacy length limits in build_search_view and build_filter_panel

- Add autosave and 50px max width to grid border config
- Replace wildcard import with explicit imports in search_view.rs

- Replace closure with OsStr::to_str in interaction.rs
@nicx17 nicx17 changed the title Persistent search form, explore places filter, clippy fixes Dedicated search view, explore places filter, Gird border Aug 30, 2026
@nicx17 nicx17 linked an issue Aug 30, 2026 that may be closed by this pull request
Border gap now insets the content area so the same gap appears between tiles and between tiles and the window edges (top, bottom, left, right).
@sonarqubecloud

Copy link
Copy Markdown

@nicx17

nicx17 commented Aug 30, 2026

Copy link
Copy Markdown
Owner Author

Implemented border feature

image

@nicx17
nicx17 merged commit c9e0836 into main Aug 30, 2026
12 checks passed
@nicx17
nicx17 deleted the feature/sidebar-search branch August 30, 2026 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add configurable border for masonary grid

1 participant