Disable preferSwiftStringAPI by default due to iOS 16 / macOS 13 API availability#2495
Merged
calda merged 1 commit intonicklockwood:developfrom Apr 11, 2026
Conversation
a2549e5 to
b7fd609
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2495 +/- ##
========================================
Coverage 95.30% 95.30%
========================================
Files 168 168
Lines 25383 25383
========================================
+ Hits 24191 24192 +1
+ Misses 1192 1191 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replacing(_:with:)is only available on iOS 16+ / macOS 13+. For example, the SwiftFormat codebase no longer compiles when the rule is applied, since the minimum macOS version is 10.14.Eventually we could add something like
--apple-os-version 26that would let us have these sorts of things be enabled by default, but gated behind OS version like how we gate functionality by Swift version. The unified 26.0 / 27.0 version numbers will make this easy eventually but for now it's still a bit tricky.