Sanitize X-ALT-DESC HTML in ICS output - #1190
Open
RasputinKaiser wants to merge 1 commit into
Open
Conversation
RasputinKaiser
force-pushed
the
codex/openpledge-owc-1187-x-alt-desc
branch
from
May 12, 2026 00:53
700951a to
6a116e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/calendar.ics, while preserving parameters such asFMTTYPE=text/htmlFixes #1187.
Duplicate check
gh pr list --repo niccokunzmann/open-web-calendar --base main --state all --search "1187 X-ALT-DESC sanitize"returned no PRsgh pr list --repo niccokunzmann/open-web-calendar --base main --state all --search "X-ALT-DESC"only found merged Strip HTML from VEVENT DESCRIPTION in ICS output #1185, which intentionally preserved X-ALT-DESC verbatim and is the adjacent prerequisite this builds onTests
.venv/bin/python -m pytest open_web_calendar/test/test_issue_167_html_in_description.py open_web_calendar/test/test_issue_466_merge_calendars_into_ics.py -q.venv/bin/python -m ruff check open_web_calendar/convert/ics.py open_web_calendar/test/test_issue_167_html_in_description.py open_web_calendar/test/test_issue_466_merge_calendars_into_ics.pygit diff --checkpython3fork-mode Behave run forfeatures/issue-206-subscribe-to-ics.feature:3open_web_calendar/features/downloads/2024-03-22 Head Start Menu (ages 3-5).ics