deprecate(inject-lazy): deprecate injectLazy in favor of Angular v22 injectAsync#691
deprecate(inject-lazy): deprecate injectLazy in favor of Angular v22 injectAsync#691eneajaho wants to merge 3 commits into
Conversation
…favor of Angular v22 injectAsync Closes #685 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
View your CI Pipeline Execution ↗ for commit e9b6347
☁️ Nx Cloud last updated this comment at |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request deprecates the injectLazy utility in favor of Angular's native injectAsync and introduces a local configuration file for Claude. Review feedback highlights factual inaccuracies in the deprecation documentation regarding the Angular version and PR link, and suggests that the local settings file should be added to .gitignore instead of being committed to the repository.
I am having trouble creating individual review comments. Click here to see my feedback.
libs/ngxtension/inject-lazy/src/inject-lazy-impl.ts (79-80)
The JSDoc references Angular v22 and PR #68248. However, Angular v19 is the current major version, and injectAsync is expected to be available in v19.x. Additionally, the PR number #68248 appears to be outside the current range of the Angular repository. These details are likely inaccuracies from the AI tool used to generate this PR and should be corrected to avoid misleading users.
libs/ngxtension/inject-lazy/src/inject-lazy.ts (14-15)
The JSDoc references Angular v22 and PR #68248. However, Angular v19 is the current major version, and injectAsync is expected to be available in v19.x. Additionally, the PR number #68248 appears to be outside the current range of the Angular repository. These details are likely inaccuracies from the AI tool used to generate this PR and should be corrected to avoid misleading users.
.claude/settings.local.json (1-5)
This file appears to be a local configuration for the Claude Code tool. Local settings files, especially those with .local in the name, should typically be added to .gitignore rather than committed to the repository. This prevents environment-specific configurations from being shared and potentially overriding other contributors' settings.
…lar v22 injectAsync - Adds ts-morph-based migration that rewrites the import from 'ngxtension/inject-lazy' to '@angular/core', renames injectLazy to injectAsync at every call site, merges into existing @angular/core imports where present, and removes the unsupported explicit injector argument (printing a warning for affected files) - Registers the migration in migrations.json at version 8.0.0 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Ship it :D |
2 participants
Summary
@deprecatedJSDoc toinjectLazypointing users to Angular's built-ininjectAsync(available in Angular v22, see feat(core): Add aninjectAsynchelper function angular/angular#68248)@deprecatedJSDoc to the companionmockLazyProvidertest helpermockLazyProvider's existing JSDoc (was incorrectly referencinginjectAsyncinstead ofinjectLazy)Closes #685
Test plan
pnpm exec nx run ngxtension/inject-lazy:test— all 5 tests pass@deprecatedtag🤖 Generated with Claude Code