Only build the go binary if the source files have changed by pdabelf5 · Pull Request #9266 · nginx/kubernetes-ingress

pdabelf5 · 2026-02-27T10:44:55Z

Proposed changes

To speed up compilation, only perform a go build if the source files are newer than the binary.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

I have read the CONTRIBUTING doc
I have added tests that prove my fix is effective or that my feature works
I have checked that all unit tests pass after adding my changes
I have updated necessary documentation
I have rebased my branch onto main
I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Copilot

Pull request overview

Updates the root Makefile to speed up local builds by turning the ingress controller binary into a file target so make can skip go build when inputs haven’t changed.

Changes:

Introduce BINARY_NAME and use it for build/debug/clean output naming.
Add GO_SRCS and make $(BINARY_NAME) depend on it to enable incremental rebuilds.
Update build to invoke $(MAKE) $(BINARY_NAME) for TARGET=local.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Makefile

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Paul Abel <128620221+pdabelf5@users.noreply.github.com>

codecov · 2026-02-27T10:59:22Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 54.37%. Comparing base (c15ff6d) to head (35e6572).
⚠️ Report is 125 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #9266      +/-   ##
==========================================
+ Coverage   53.95%   54.37%   +0.41%     
==========================================
  Files          91       97       +6     
  Lines       18692    19324     +632     
==========================================
+ Hits        10086    10507     +421     
- Misses       8075     8236     +161     
- Partials      531      581      +50

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2026-02-27T11:13:32Z

Package Report

Details

gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-fb95e7984526ed67081c06c0f17ec56c, nginx, 1.29.5-1~trixie, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-fb95e7984526ed67081c06c0f17ec56c, nginx-module-njs, 1.29.5+0.9.5-1~trixie, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-fb95e7984526ed67081c06c0f17ec56c, nginx-module-otel, 1.29.5+0.1.2-1~trixie, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-fb95e7984526ed67081c06c0f17ec56c, nginx-agent, 3.7.2~trixie, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-fb95e7984526ed67081c06c0f17ec56c, nginx, 1.29.5-1~trixie, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-fb95e7984526ed67081c06c0f17ec56c, nginx-module-njs, 1.29.5+0.9.5-1~trixie, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-fb95e7984526ed67081c06c0f17ec56c, nginx-module-otel, 1.29.5+0.1.2-1~trixie, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-fb95e7984526ed67081c06c0f17ec56c, nginx-agent, 3.7.2~trixie, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c, nginx-plus, 36-3~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c, nginx-plus-module-njs, 36+0.9.5-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c, nginx-plus-module-otel, 36+0.1.2-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c, nginx-plus-module-fips-check, 36+0.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c, nginx-agent, 3.7.2~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c, nginx-plus, 36-3~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c, nginx-plus-module-njs, 36+0.9.5-1~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c, nginx-plus-module-otel, 36+0.1.2-1~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c, nginx-plus-module-fips-check, 36+0.1-1~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c, nginx-agent, 3.7.2~bookworm, arm64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c, nginx-plus, 36-3~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c, nginx-plus-module-njs, 36+0.9.5-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c, nginx-plus-module-otel, 36+0.1.2-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c, nginx-plus-module-fips-check, 36+0.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c, nginx-plus-module-appprotect, 36+5.575.2-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c, app-protect, 36+5.575.2-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c, app-protect-attack-signatures, 2026.02.25-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c, app-protect-threat-campaigns, 2026.02.22-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c, nginx-agent, 2.45.2~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c, nginx-plus, 36-3~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c, nginx-plus-module-njs, 36+0.9.5-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c, nginx-plus-module-otel, 36+0.1.2-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c, nginx-plus-module-fips-check, 36+0.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c, nginx-plus-module-appprotect, 36+5.575.2-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c, app-protect-module-plus, 36+5.575.2-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c, app-protect-plugin, 6.25.0-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c, nginx-agent, 2.45.2~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c, nginx-plus, 36-3~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c, nginx-plus-module-njs, 36+0.9.5-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c, nginx-plus-module-otel, 36+0.1.2-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c, nginx-plus-module-fips-check, 36+0.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c, nginx-plus-module-appprotectdos, 36+4.8.3-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c, app-protect-dos, 36+4.8.3-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c, nginx-plus, 36-3~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c, nginx-plus-module-njs, 36+0.9.5-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c, nginx-plus-module-otel, 36+0.1.2-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c, nginx-plus-module-fips-check, 36+0.1-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c, nginx-plus-module-appprotect, 36+5.575.2-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c, app-protect, 36+5.575.2-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c, app-protect-attack-signatures, 2026.02.25-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c, app-protect-threat-campaigns, 2026.02.22-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c, nginx-plus-module-appprotectdos, 36+4.8.3-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c, app-protect-dos, 36+4.8.3-1~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c, nginx-agent, 2.45.2~bookworm, amd64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-fb95e7984526ed67081c06c0f17ec56c-alpine, nginx, 1.29.5-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-fb95e7984526ed67081c06c0f17ec56c-alpine, nginx-module-njs, 1.29.5.0.9.5-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-fb95e7984526ed67081c06c0f17ec56c-alpine, nginx-module-otel, 1.29.5.0.1.2-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-fb95e7984526ed67081c06c0f17ec56c-alpine, nginx-agent, 3.7.2, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-fb95e7984526ed67081c06c0f17ec56c-alpine, nginx, 1.29.5-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-fb95e7984526ed67081c06c0f17ec56c-alpine, nginx-module-njs, 1.29.5.0.9.5-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-fb95e7984526ed67081c06c0f17ec56c-alpine, nginx-module-otel, 1.29.5.0.1.2-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-fb95e7984526ed67081c06c0f17ec56c-alpine, nginx-agent, 3.7.2, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-alpine, nginx-plus, 36-r3, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-alpine, nginx-plus-module-njs, 36.0.9.5-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-alpine, nginx-plus-module-otel, 36.0.1.2-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-alpine, nginx-plus-module-fips-check, 36.0.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-alpine, nginx-agent, 3.7.2, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-alpine, nginx-plus, 36-r3, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-alpine, nginx-plus-module-njs, 36.0.9.5-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-alpine, nginx-plus-module-otel, 36.0.1.2-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-alpine, nginx-plus-module-fips-check, 36.0.1-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-alpine, nginx-agent, 3.7.2, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-alpine-fips, nginx-plus, 36-r3, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-alpine-fips, nginx-plus-module-njs, 36.0.9.5-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-alpine-fips, nginx-plus-module-otel, 36.0.1.2-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-alpine-fips, nginx-plus-module-fips-check, 36.0.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-alpine-fips, nginx-agent, 3.7.2, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-alpine-fips, nginx-plus, 36-r3, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-alpine-fips, nginx-plus-module-njs, 36.0.9.5-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-alpine-fips, nginx-plus-module-otel, 36.0.1.2-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-alpine-fips, nginx-plus-module-fips-check, 36.0.1-r1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-alpine-fips, nginx-agent, 3.7.2, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-alpine-fips, nginx-plus, 36-r3, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-alpine-fips, nginx-plus-module-njs, 36.0.9.5-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-alpine-fips, nginx-plus-module-otel, 36.0.1.2-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-alpine-fips, nginx-plus-module-fips-check, 36.0.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-alpine-fips, nginx-agent, 2.45.2, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-alpine-fips, nginx-plus-module-appprotect, 36.5.575.2-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-alpine-fips, app-protect, 36.5.575.2-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-alpine-fips, app-protect-attack-signatures, 2026.02.25-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-alpine-fips, app-protect-threat-campaigns, 2026.02.22-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-alpine-fips, nginx-plus, 36-r3, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-alpine-fips, nginx-plus-module-njs, 36.0.9.5-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-alpine-fips, nginx-plus-module-otel, 36.0.1.2-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-alpine-fips, nginx-plus-module-fips-check, 36.0.1-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-alpine-fips, nginx-agent, 2.45.2, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-alpine-fips, nginx-plus-module-appprotect, 36.5.575.2-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-alpine-fips, app-protect-module-plus, 36.5.575.2-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-alpine-fips, app-protect-plugin, 6.25.0-r1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, nginx, 1.29.5-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, nginx-module-njs, 1.29.5+0.9.5-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, nginx-module-otel, 1.29.5+0.1.2-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, nginx-agent, 3.7.2-1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, nginx, 1.29.5-1.el9.ngx, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, nginx-module-njs, 1.29.5+0.9.5-1.el9.ngx, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, nginx-module-otel, 1.29.5+0.1.2-1.el9.ngx, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, nginx-agent, 3.7.2-1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, nginx-plus, 36-3.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, nginx-plus-module-njs, 36+0.9.5-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, nginx-plus-module-otel, 36+0.1.2-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, nginx-plus-module-fips-check, 36+0.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, nginx-agent, 3.7.2-1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, nginx-plus, 36-3.el9.ngx, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, nginx-plus-module-njs, 36+0.9.5-1.el9.ngx, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, nginx-plus-module-otel, 36+0.1.2-1.el9.ngx, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, nginx-plus-module-fips-check, 36+0.1-1.el9.ngx, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, nginx-agent, 3.7.2-1, aarch64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, nginx-plus, 36-3.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, nginx-plus-module-njs, 36+0.9.5-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, nginx-plus-module-otel, 36+0.1.2-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, nginx-plus-module-fips-check, 36+0.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, nginx-agent, 2.45.2-1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, nginx-plus-module-appprotect, 36+5.575.2-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, app-protect, 36+5.575.2-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, app-protect-attack-signatures, 2026.02.25-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, app-protect-threat-campaigns, 2026.02.22-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, nginx-plus, 36-3.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, nginx-plus-module-njs, 36+0.9.5-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, nginx-plus-module-otel, 36+0.1.2-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, nginx-plus-module-fips-check, 36+0.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, nginx-agent, 2.45.2-1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, nginx-plus-module-appprotect, 36+5.575.2-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, app-protect-module-plus, 36+5.575.2-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, app-protect-plugin, 6.25.0-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi8, nginx-plus, 36-3.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi8, nginx-plus-module-njs, 36+0.9.5-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi8, nginx-plus-module-otel, 36+0.1.2-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi8, nginx-plus-module-fips-check, 36+0.1-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi8, nginx-agent, 2.45.2-1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi8, nginx-plus-module-appprotect, 36+5.575.2-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi8, app-protect, 36+5.575.2-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi8, app-protect-attack-signatures, 2026.02.25-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi8, app-protect-threat-campaigns, 2026.02.22-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi8, nginx-plus, 36-3.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi8, nginx-plus-module-njs, 36+0.9.5-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi8, nginx-plus-module-otel, 36+0.1.2-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi8, nginx-plus-module-fips-check, 36+0.1-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi8, nginx-agent, 2.45.2-1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi8, nginx-plus-module-appprotect, 36+5.575.2-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi8, app-protect-module-plus, 36+5.575.2-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-nap-v5/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi8, app-protect-plugin, 6.25.0-1.el8.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, nginx-plus, 36-3.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, nginx-plus-module-njs, 36+0.9.5-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, nginx-plus-module-otel, 36+0.1.2-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, nginx-plus-module-fips-check, 36+0.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, nginx-plus-module-appprotectdos, 36+4.8.3-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, app-protect-dos, 36+4.8.3-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, nginx-plus, 36-3.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, nginx-plus-module-njs, 36+0.9.5-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, nginx-plus-module-otel, 36+0.1.2-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, nginx-plus-module-fips-check, 36+0.1-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, nginx-plus-module-appprotect, 36+5.575.2-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, nginx-plus-module-appprotectdos, 36+4.8.3-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, nginx-agent, 2.45.2-1, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, app-protect, 36+5.575.2-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, app-protect-attack-signatures, 2026.02.25-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, app-protect-threat-campaigns, 2026.02.22-1.el9.ngx, x86_64
gcr.io/f5-gcs-7899-ptg-ingrss-ctlr/dev/nginx-ic-dos-nap/nginx-plus-ingress:t-fb95e7984526ed67081c06c0f17ec56c-ubi, app-protect-dos, 36+4.8.3-1.el9.ngx, x86_64

Copilot

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-02-27T11:21:09Z

Makefile

 else ifeq ($(strip $(TARGET)),debug)
 	@go version || (code=$$?; printf "\033[0;31mError\033[0m: unable to build locally, try using the parameter TARGET=container or TARGET=download\n"; exit $$code)
-	CGO_ENABLED=0 GOOS=$(strip $(GOOS)) GOARCH=$(strip $(ARCH)) go build -ldflags "$(DEBUG_GO_LINKER_FLAGS)" -gcflags "$(DEBUG_GO_GC_FLAGS)" -o nginx-ingress github.com/nginx/kubernetes-ingress/cmd/nginx-ingress
+	CGO_ENABLED=0 GOOS=$(strip $(GOOS)) GOARCH=$(strip $(ARCH)) go build -ldflags "$(DEBUG_GO_LINKER_FLAGS)" -gcflags "$(DEBUG_GO_GC_FLAGS)" -o $(BINARY_NAME) github.com/nginx/kubernetes-ingress/cmd/nginx-ingress


The debug build target bypasses the new incremental build logic. When TARGET=debug, this code directly builds the binary without checking if source files have changed, which is inconsistent with the regular build flow. Consider changing this to use the $(BINARY_NAME) target as well, but with different flags. However, this would require creating a separate target or conditionally setting the build flags.

Copilot · 2026-02-27T11:21:10Z

Makefile

 	go generate internal/telemetry/exporter.go
 	gofumpt -w internal/telemetry/*_generated.go

+$(BINARY_NAME): $(GO_SRCS) ## Build Ingress Controller binary (local)


The $(BINARY_NAME) target doesn't depend on variables that affect the build output. If GO_LINKER_FLAGS changes (e.g., VERSION or TELEMETRY_ENDPOINT), the binary won't be rebuilt because these variables aren't in the dependency list. This means the binary could contain stale version information. Consider if this optimization is worth the risk of stale metadata in the binary.

Suggested change

$(BINARY_NAME): $(GO_SRCS) ## Build Ingress Controller binary (local)

.ldflags.stamp:

@printf '%s\n' "$(GO_LINKER_FLAGS)" | cmp -s - .ldflags.stamp 2>/dev/null || printf '%s\n' "$(GO_LINKER_FLAGS)" > .ldflags.stamp

$(BINARY_NAME): $(GO_SRCS) .ldflags.stamp ## Build Ingress Controller binary (local)

Only build the go binary if the source files have changed

027f4cf

Copilot AI review requested due to automatic review settings February 27, 2026 10:44

pdabelf5 requested a review from a team as a code owner February 27, 2026 10:44

github-project-automation bot added this to NGINX Ingress Controller Feb 27, 2026

github-project-automation bot moved this to Todo ☑ in NGINX Ingress Controller Feb 27, 2026

github-actions bot added the chore Pull requests for routine tasks label Feb 27, 2026

Copilot started reviewing on behalf of pdabelf5 February 27, 2026 10:45 View session

Copilot AI reviewed Feb 27, 2026

View reviewed changes

Makefile Outdated Show resolved Hide resolved

Makefile Outdated Show resolved Hide resolved

Makefile Outdated Show resolved Hide resolved

Makefile Outdated Show resolved Hide resolved

Makefile Outdated Show resolved Hide resolved

pdabelf5 and others added 2 commits February 27, 2026 10:51

Update Makefile

7dc3dd7

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Paul Abel <128620221+pdabelf5@users.noreply.github.com>

Update Makefile

35e6572

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Paul Abel <128620221+pdabelf5@users.noreply.github.com>

AlexFenlon requested a review from Copilot February 27, 2026 11:17

Copilot started reviewing on behalf of AlexFenlon February 27, 2026 11:18 View session

Copilot AI reviewed Feb 27, 2026

View reviewed changes

pdabelf5 added 2 commits February 27, 2026 15:21

Build a binary with the architecture name included

8fb397c

Only run docker when trying to download the binary from a container

acdab0b

AlexFenlon approved these changes Mar 2, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Only build the go binary if the source files have changed#9266

Only build the go binary if the source files have changed#9266
pdabelf5 wants to merge 5 commits intomainfrom
chore/go-make

pdabelf5 commented Feb 27, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Feb 27, 2026

Uh oh!

github-actions bot commented Feb 27, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Feb 27, 2026

Uh oh!

Copilot AI Feb 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

-$(BINARY_NAME): $(GO_SRCS) ## Build Ingress Controller binary (local)
+.ldflags.stamp:
+	@printf '%s\n' "$(GO_LINKER_FLAGS)" | cmp -s - .ldflags.stamp 2>/dev/null || printf '%s\n' "$(GO_LINKER_FLAGS)" > .ldflags.stamp
+$(BINARY_NAME): $(GO_SRCS) .ldflags.stamp ## Build Ingress Controller binary (local)

Conversation

pdabelf5 commented Feb 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Feb 27, 2026

Codecov Report

Uh oh!

github-actions bot commented Feb 27, 2026

Package Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 27, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pdabelf5 commented Feb 27, 2026 •

edited

Loading