fix: prevent duplicate Host header in proxy configurations#9145
Open
Annefr27 wants to merge 1 commit intonginx:mainfrom
Open
fix: prevent duplicate Host header in proxy configurations#9145Annefr27 wants to merge 1 commit intonginx:mainfrom
Annefr27 wants to merge 1 commit intonginx:mainfrom
Conversation
Contributor
|
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
Author
|
I have hereby read the F5 CLA and agree to its terms |
Contributor
Author
Hi @AlexFenlon, I don't understand why 2 contributors have been detected. |
Contributor
|
Can you please rebase with just commit using the @Annefr27 user please as the checks we have will not work otherwise, sorry! |
In Ingress, when users define Host header in nginx.org/proxy-set-headers annotations, it was being duplicated because the code always added a default Host header automatically.
fa6318f to
20054ac
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Ingress, when users define Host header in nginx.org/proxy-set-headers annotations, it was being duplicated because the code always added a default Host header automatically. The value set via the annotation had no effect.
Proposed changes
Remove the default "Host" header setting from nginx.ingress.tmpl and nginx-plus.ingress.tmpl template files.
Adds the "Host" header dynamically. If it is not defined in "master" or "minions", the default value "proxy_set_header Host $host;" is added.
This PR refers to Issue #8992
Checklist
Before creating a PR, run through this checklist and mark each as complete.