-
Notifications
You must be signed in to change notification settings - Fork 66
Add NXgoniometer base class #1561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rayosborn
wants to merge
10
commits into
nexusformat:main
Choose a base branch
from
rayosborn:add-nxgoniometer-class
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
7ece7f8
Initial draft of the NXgoniometer base class
rayosborn ed4c99f
Use placeholder names for the rotation angles and sample translations
rayosborn b3a7bee
Enable alternative coordinate systems
rayosborn 34cacd7
Make the class inherit from NXcomponent
rayosborn 5059066
Adds this base class to NXinstrument.
rayosborn a73d50e
Fix indentation
rayosborn 9d4ba9b
Remove claims to have travelled in time
rayosborn 8c9498f
Remove NXcoordinate_system
rayosborn 9afaa12
Add documentation about us of NXtransformations
rayosborn 7e3d3ab
Fix indentation
rayosborn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <?xml-stylesheet type="text/xsl" href="nxdlformat.xsl" ?> | ||
| <!-- | ||
| # NeXus - Neutron and X-ray Common Data Format | ||
| # | ||
| # Copyright (C) 2025 NeXus International Advisory Committee (NIAC) | ||
| # | ||
| # This library is free software; you can redistribute it and/or | ||
| # modify it under the terms of the GNU Lesser General Public | ||
| # License as published by the Free Software Foundation; either | ||
| # version 3 of the License, or (at your option) any later version. | ||
| # | ||
| # This library is distributed in the hope that it will be useful, | ||
| # but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU | ||
| # Lesser General Public License for more details. | ||
| # | ||
| # You should have received a copy of the GNU Lesser General Public | ||
| # License along with this library; if not, write to the Free Software | ||
| # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA | ||
| # | ||
| # For further information, see http://www.nexusformat.org | ||
| --> | ||
| <definition xmlns="http://definition.nexusformat.org/nxdl/3.1" category="base" | ||
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:schemaLocation="http://definition.nexusformat.org/nxdl/3.1 ../nxdl.xsd" | ||
| name="NXgoniometer" type="group" extends="NXcomponent"> | ||
|
|
||
| <doc> | ||
| Goniometer rotation angles and sample translations used during a | ||
| measurement. The goniometers used at neutron and x-ray | ||
| facilities are typically four-circle or six-circle goniometers, | ||
| or variants of either one. There is no universally recognized | ||
| naming convention for angles and translations, so the group | ||
| should contain a :ref:`NXcite` group, which describes how the | ||
| angles are defined. | ||
|
|
||
| If the goniometer settings are part of a transformation chain, | ||
| it is possible to record them as NXtransformation groups instead | ||
| of as fields. It is still recommended that the names of the | ||
| groups adhere to the convention referenced in the NXcite group. | ||
| </doc> | ||
|
|
||
| <group name="convention" type="NXcite"> | ||
| <doc> | ||
| A reference to a publication or online documentation that | ||
| describe the convention used in this group to define the | ||
| names of angles and sample translations. | ||
| </doc> | ||
| </group> | ||
| <field name="goniometer"> | ||
| <doc> | ||
| The common name for the type of goniometer used in these | ||
| measurements. | ||
| </doc> | ||
| </field> | ||
| <field name="ROTATION_ANGLE" type="NX_FLOAT" units="NX_ANGLE" nameType="any"> | ||
| <doc> | ||
| One of the goniometer rotation angles defined by the | ||
| specified convention. | ||
| </doc> | ||
| </field> | ||
rayosborn marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| <field name="SAMPLE_TRANSLATION" type="NX_FLOAT" units="NX_LENGTH" nameType="any"> | ||
PeterC-DLS marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| <doc> | ||
| The translation of the sample from the centre of rotation of | ||
| the goniometer angles along one of the coordinate axes. | ||
| </doc> | ||
| </field> | ||
|
|
||
| </definition> | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.