-
Notifications
You must be signed in to change notification settings - Fork 23
Description
(Originally flagged the obsolete reverse column in #207 (comment))
Reverse complement sequences were initially manually flagged by the reverse column added in #79.
Since Nextclade v2.2.0, there's a built-in --retry-reverse-complement option that adds a new column isReverseComplement. This feature was used in the ingest pipeline starting from #89. Then in #94, the ingest/bin/reverse_reversed_sequences.py script was replaced with the built-in Nextclade functionality as well.
In #191, the phylogenetic pipeline switched over from using the reverse column to the is_reverse_complement column output from Nextclade. This seemingly makes the reverse column obsolete. When checking the latest metadata TSV (2023-10-13), the reverse column is completely empty.
From my point of view, we can just remove the reverse column from the metadata.tsv file, but wanted to confirm with other users of the pipeline/metadata.tsv file (cc: @corneliusroemer, @chaoran-chen).