Open
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
15aff59 to
9b4afdb
Compare
9b4afdb to
d43a2a7
Compare
d43a2a7 to
f52166a
Compare
6637691 to
e746625
Compare
6d4c06b to
1ade042
Compare
853ca71 to
0a18ad3
Compare
Merged
0a18ad3 to
d1d57d9
Compare
d1d57d9 to
f8e013c
Compare
Member
Turns out this already happens and we don't have to change anything: |
f8e013c to
b9d99f2
Compare
Signed-off-by: Max <max@nextcloud.com>
The pushing does not happen yet - thus the test is failing. Signed-off-by: Max <max@nextcloud.com>
Expose the update mechanism inside the websocket provider. This is normally triggered by updates of the ydoc. But as the updates happened while offline in a previous session we need to trigger it explicitely. The websocket provider holds the remote state of the document. So it can compute an update based on this and the current ydoc. Signed-off-by: Max <max@nextcloud.com>
…ode) Signed-off-by: silver <s.szmajduch@posteo.de>
… (ai code) Signed-off-by: silver <s.szmajduch@posteo.de>
Signed-off-by: silver <s.szmajduch@posteo.de>
Signed-off-by: silver <s.szmajduch@posteo.de>
Signed-off-by: silver <s.szmajduch@posteo.de>
Signed-off-by: silver <s.szmajduch@posteo.de>
Signed-off-by: silver <s.szmajduch@posteo.de>
Signed-off-by: silver <s.szmajduch@posteo.de>
There might still be dangling async functions trying to write to IndexedDB after `clearIndexedDB()` was called. Guard against these race conditions. Generated with the help of AI but verified and implemented manually. Signed-off-by: Jonas <jonas@freesources.org>
Needed so local changes don't get lost when editor is closed in case of conflict. Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: silver <s.szmajduch@posteo.de>
f4a20a8 to
ca0bda6
Compare
silverkszlo
reviewed
Apr 23, 2026
Fixes 'no conflict when uploading identical content with unsaved changes' Signed-off-by: Jonas <jonas@freesources.org>
…alog Rename buttons to hopefully make them more understandable. Signed-off-by: silver <s.szmajduch@posteo.de>
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
Signed-off-by: Jonas <jonas@freesources.org>
Requests might take a few seconds before getting triggered once we're back online. Signed-off-by: Jonas <jonas@freesources.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODOs
base_version_etagas custom property to IndexedDBbaseVersionEtagas part of create requestbaseVersionEtag.readerSourceproperty forCollissionResolveDialogis still needed (see here)