Feature/deep link launcher support#6207
Merged
Merged
Conversation
mahibi
force-pushed
the
feature/deep-link-launcher-support
branch
from
4b65b08 to
28dfc26
Compare
- Add custom URI scheme (nctalk://conversation/{token}) for opening
conversations from external launchers like KISS
- Add HTTPS deep link support for /call/{token} URLs (fixes #847)
- Add dynamic shortcuts for favorite/recent conversations
- Add "Add to home screen" menu option in conversation long-press dialog
- New DeepLinkHandler utility for parsing deep link URIs
- New ShortcutManagerHelper utility for managing conversation shortcuts
Signed-off-by: angrymuesli <github.visibly626@slmails.com>
Address maintainer feedback and improve code quality: - Replace nctalk:// with nextcloudtalk:// custom URI scheme - Remove HTTPS deep links (not feasible for self-hosted domains) - Add token validation (alphanumeric, 4-32 chars) - Fix server URL matching to use proper host comparison - Handle null user.id gracefully in ShortcutManagerHelper - Manage RxJava disposables to prevent memory leaks - Add lifecycle checks before UI operations - Fix generic exception handling URI format: nextcloudtalk://[user@]host/[base/]call/token Signed-off-by: angrymuesli <github.visibly626@slmails.com>
- Align "Add to home screen" menu icon and text padding with other bottom dialog items (use standard_dialog_padding consistently) - Disable shortcuts when a conversation is deleted so pinned shortcuts show "conversation no longer exists" instead of broken navigation - Use nextcloudtalk:// deep link URIs in shortcuts instead of bundle extras to fix multi-account navigation bug where switching accounts via shortcut would show conversation list instead of the conversation Signed-off-by: angrymuesli <github.visibly626@slmails.com>
…-stack - Disable shortcuts when deleting or leaving a conversation from ConversationInfoActivity (previously only handled in bottom dialog) - Fix back-stack for deep link navigation: open ConversationsListActivity before ChatActivity so pressing back shows the correct user's conversation list instead of stale data from a previous account Signed-off-by: angrymuesli <github.visibly626@slmails.com>
Upstream migrated the conversation bottom dialog to a Compose ModalBottomSheet. Adapt our shortcut features to the new architecture: - Add AddToHomeScreen action to ConversationOpsAction sealed class - Add "Add to home screen" menu item in ConversationOperationsSheet - Wire handler in ConversationsListActivity.handleConversationOpsAction - Fix back-stack: pass KEY_INTERNAL_USER_ID to ConversationsListActivity via intent so it reads the correct user from DB instead of stale cache Signed-off-by: angrymuesli <github.visibly626@slmails.com>
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
solution is to use singleTask for MainActivity steps to reproduce: 1. have an app instance opened 2. go to another app that contains the deep link & click it without this fix: another talk app instance is opened with this fix: the existing app instance is opened Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
mahibi
force-pushed
the
feature/deep-link-launcher-support
branch
from
0b563cc to
483a46e
Compare
6 tasks
Contributor
|
APK file: https://github.com/nextcloud/talk-android/actions/runs/25922943364/artifacts/7021634613 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
copied commits from #5664 to rebase on master and fix conflicts and try to merge for RC1
Thanks to https://github.com/angrymuesli !
🏁 Checklist
/backport to stable-xx.x