Skip to content

Update WebSocket data handling for files and system messages#6124

Merged
mahibi merged 1 commit into
masterfrom
issue-6081-websocket-rest-calls
May 12, 2026
Merged

Update WebSocket data handling for files and system messages#6124
mahibi merged 1 commit into
masterfrom
issue-6081-websocket-rest-calls

Conversation

@anakin78z
Copy link
Copy Markdown
Contributor

@anakin78z anakin78z commented Apr 25, 2026

See #6081

When receiving a WebSocket chat comment with a file attachment, fetch messages via REST call to get user specific file paths.
This allows the user to display media without needing to wait on the insurance call to trigger.

Also checks for system messages that need to be localized for the user. This follows the logic of the web app. However, since it doesn't look like we do localization in the Android app, it's set to fetch new data for any system message that is not on the list of untranslated system messages. Partially implements #6064

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@github-actions
Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/talk-android/actions/runs/24935776966/artifacts/6641289039
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@anakin78z anakin78z force-pushed the issue-6081-websocket-rest-calls branch from 125869b to 41acb4b Compare April 26, 2026 16:17
@anakin78z anakin78z changed the title [WIP] Update WebSocket data handling for files Update WebSocket data handling for files and system messages Apr 26, 2026
@anakin78z anakin78z marked this pull request as ready for review April 26, 2026 16:21
@github-actions
Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/talk-android/actions/runs/24961225772/artifacts/6648778858
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@github-actions
Copy link
Copy Markdown
Contributor

Codacy

Lint

TypemasterPR
Warnings8888
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1010
Dodgy code5353
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total8080

@mahibi
Copy link
Copy Markdown
Collaborator

mahibi commented Apr 29, 2026

will have a look soon!

@mahibi
Copy link
Copy Markdown
Collaborator

mahibi commented May 5, 2026

still on our list. Review is not forgotten

@github-actions
Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@mahibi
Copy link
Copy Markdown
Collaborator

mahibi commented May 12, 2026

We are now trying to catch up with the pull request reviews. The PR is not forgotten and should be picked up soon.

…a, fetch new messages via REST call.

Signed-off-by: Jens Zalzala <jens@shakingearthdigital.com>
@mahibi mahibi force-pushed the issue-6081-websocket-rest-calls branch from 41acb4b to 745ba31 Compare May 12, 2026 13:55
@mahibi mahibi merged commit 003f885 into master May 12, 2026
13 of 17 checks passed
@mahibi mahibi deleted the issue-6081-websocket-rest-calls branch May 12, 2026 14:00
@mahibi
Copy link
Copy Markdown
Collaborator

mahibi commented May 12, 2026

Thank you @anakin78z 👍

@github-actions
Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/talk-android/actions/runs/25739124510/artifacts/6947431827
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@AndyScherzinger AndyScherzinger added this to the 24.0.0 milestone May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants