Skip to content

⚒️🎨 Migrate ConversationInfo to Composable#6048

Open
AndyScherzinger wants to merge 3 commits into
masterfrom
style/noid/conversationInfoComposable
Open

⚒️🎨 Migrate ConversationInfo to Composable#6048
AndyScherzinger wants to merge 3 commits into
masterfrom
style/noid/conversationInfoComposable

Conversation

@AndyScherzinger
Copy link
Copy Markdown
Member

@AndyScherzinger AndyScherzinger commented Apr 12, 2026

🖼️ Screenshots

🏚️ Before 🏡 After
B A

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@AndyScherzinger AndyScherzinger added the 2. developing Work in progress label Apr 12, 2026
@AndyScherzinger AndyScherzinger added this to the 24.0.0 milestone Apr 12, 2026
@AndyScherzinger AndyScherzinger force-pushed the style/noid/conversationInfoComposable branch 9 times, most recently from 71ffa94 to 4671393 Compare April 14, 2026 14:12
@AndyScherzinger AndyScherzinger marked this pull request as ready for review April 14, 2026 15:08
@AndyScherzinger AndyScherzinger added design Related to the design 3. to review Waiting for reviews technical debt Technical issue and removed 2. developing Work in progress labels Apr 14, 2026
@AndyScherzinger AndyScherzinger force-pushed the style/noid/conversationInfoComposable branch 2 times, most recently from 8d9b134 to 362a234 Compare April 16, 2026 09:22
@AndyScherzinger AndyScherzinger force-pushed the style/noid/conversationInfoComposable branch 2 times, most recently from cb81f29 to fae6178 Compare April 24, 2026 16:20
Copy link
Copy Markdown
Contributor

@sowjanyakch sowjanyakch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and noticed a small issue. Avatar for groups and teams are not displayed in the participants section.

Image

@AndyScherzinger
Copy link
Copy Markdown
Member Author

Thanks for the finding, didn't think of teams... Only tested users as attendees

@AndyScherzinger AndyScherzinger force-pushed the style/noid/conversationInfoComposable branch from fae6178 to f6af210 Compare April 30, 2026 16:33
@AndyScherzinger AndyScherzinger dismissed sowjanyakch’s stale review April 30, 2026 16:34

Review comments have been addressed.

@AndyScherzinger
Copy link
Copy Markdown
Member Author

@sowjanyakch fixed your remarks, thanks! Also fixed the role suffix text size 👍

@github-actions
Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/talk-android/actions/runs/25177280421/artifacts/6735409127
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@AndyScherzinger AndyScherzinger force-pushed the style/noid/conversationInfoComposable branch from f6af210 to 4ffbf42 Compare May 1, 2026 18:47
@AndyScherzinger AndyScherzinger force-pushed the style/noid/conversationInfoComposable branch from 4ffbf42 to c13f5d0 Compare May 1, 2026 21:32
Comment thread app/src/main/res/values/strings.xml Outdated
@AndyScherzinger AndyScherzinger force-pushed the style/noid/conversationInfoComposable branch from c13f5d0 to 4e1632b Compare May 12, 2026 19:57
@github-actions
Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/talk-android/actions/runs/25758716108/artifacts/6954607031
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

AI-assistant: Copilot 1.7.1-243 (Claude Sonnet 4.6)

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
…name/role alignment and unify text size

Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@AndyScherzinger AndyScherzinger force-pushed the style/noid/conversationInfoComposable branch from 4e1632b to f1216da Compare May 12, 2026 20:18
@AndyScherzinger AndyScherzinger dismissed sowjanyakch’s stale review May 12, 2026 20:19

compile issues fixed

@github-actions
Copy link
Copy Markdown
Contributor

APK file: https://github.com/nextcloud/talk-android/actions/runs/25759797740/artifacts/6955051318
To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.
qrcode (please click on link to get QR code displayed)

@nextcloud nextcloud deleted a comment from github-actions Bot May 12, 2026
@nextcloud nextcloud deleted a comment from github-actions Bot May 12, 2026
@nextcloud nextcloud deleted a comment from github-actions Bot May 12, 2026
@nextcloud nextcloud deleted a comment from github-actions Bot May 12, 2026
@nextcloud nextcloud deleted a comment from github-actions Bot May 12, 2026
@nextcloud nextcloud deleted a comment from github-actions Bot May 12, 2026
@nextcloud nextcloud deleted a comment from github-actions Bot May 12, 2026
@nextcloud nextcloud deleted a comment from github-actions Bot May 12, 2026
@nextcloud nextcloud deleted a comment from github-actions Bot May 12, 2026
@nextcloud nextcloud deleted a comment from github-actions Bot May 12, 2026
@nextcloud nextcloud deleted a comment from github-actions Bot May 12, 2026
@nextcloud nextcloud deleted a comment from github-actions Bot May 12, 2026
@nextcloud nextcloud deleted a comment from github-actions Bot May 12, 2026
@nextcloud nextcloud deleted a comment from github-actions Bot May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews design Related to the design technical debt Technical issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants